C++: New query for SSL result conflation #7242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
approved these changes
Nov 26, 2021
LGTM! Could we upgrade this query to precision high right away? It's certainly not very noisy!
|
Actually. Do you mind running DCA to make sure we don't get any re-evaluation in the suite @geoffw0? |
|
Will do... |
I'd like to tune it to detect a bit more (support more libraries and more variants of logic / flow), but the truth may be that the mistake simply isn't as common as the CWE examples led us to believe. I'm a bit reluctant to increase precision to |
|
DCA shows no significant change in performance. |
|
Great! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is the first of two new queries for CWE-295: Improper Certificate Validation.
Results:
Precision:
@medium, it's difficult to judge without seeing more real world results.Performance:
kamailio_kamailioandchakra-core(performance is great with a warmed up cache)The text was updated successfully, but these errors were encountered: