Python: Add x in <var> test for StringConstCompare
#7217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with the root cause, which is the `StringConstCompare` BarrierGuard, that does only allows `in <iterable literal>` and not `in <variable referencing iterable literal>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixing this problem is not 100% trivial. We want to track iterables that only contain string constants throughout the program (easy with type-tracking), but we probably don't want to include those that could have been modified... I don't want to go down the rabbit whole of doing that implementation right now, so this PR only adds tests cases.
The text was updated successfully, but these errors were encountered: