Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45727: Only trigger the 'did you forgot a comma' error suggestion if inside parentheses #29757

Merged
merged 1 commit into from Nov 24, 2021
Merged

bpo-45727: Only trigger the 'did you forgot a comma' error suggestion if inside parentheses #29757

merged 1 commit into from Nov 24, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 24, 2021 •
edited by miss-islington

https://bugs.python.org/issue45727

Automerge-Triggered-By: GH:pablogsal

@pablogsal pablogsal requested a review from lysnikolaou as a code owner Nov 24, 2021
@pablogsal pablogsal requested a review from isidentical Nov 24, 2021
@pablogsal
Copy link
Member Author

pablogsal commented Nov 24, 2021

CC: @cfbolz

@pablogsal pablogsal mentioned this pull request Nov 24, 2021
Merged
isidentical
isidentical approved these changes Nov 24, 2021
View changes
Copy link
Sponsor Member

@isidentical isidentical left a comment

LGTM

@pablogsal pablogsal added 🤖 automerge PR will be merged once it's been approved and all CI passed and removed needs backport to 3.10 labels Nov 24, 2021
@pablogsal pablogsal merged commit 24c10d2 into python:main Nov 24, 2021
11 of 12 checks passed
@pablogsal pablogsal deleted the comma branch Nov 24, 2021
pablogsal added a commit that referenced this pull request Nov 25, 2021
@pablogsal
[3.10] bpo-45727: Only trigger the 'did you forgot a comma' error sug…
c72311d 
…gestion if inside parentheses. (GH-29767)

Backport of GH-29757

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@pablogsal @remykarem
bpo-45727: Only trigger the 'did you forgot a comma' error suggestion…
61b3c03 
… if inside parentheses (pythonGH-29757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablogsal @isidentical @the-knights-who-say-ni @bedevere-bot