Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45020: Fix strict-prototypes warning (GH-29755) #29755

Merged
merged 1 commit into from Nov 24, 2021
Merged

bpo-45020: Fix strict-prototypes warning (GH-29755) #29755

merged 1 commit into from Nov 24, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 24, 2021 •
edited by bedevere-bot

gvanrossum
gvanrossum approved these changes Nov 24, 2021
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

I'd forgotten about that. Thanks!

@tiran tiran changed the title bpo-45020: Fix strict-prototypes warning bpo-45020: Fix strict-prototypes warning (GH-29755) Nov 24, 2021
@tiran tiran merged commit 5c4b19e into python:main Nov 24, 2021
10 of 11 checks passed
@tiran tiran deleted the bpo-45020-prototype branch Nov 24, 2021
@bedevere-bot
Copy link

bedevere-bot commented Nov 24, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.x has failed when building commit 5c4b19e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/540/builds/1439) and take a look at the build logs.
  4. Check if the failure is related to this commit (5c4b19e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/540/builds/1439

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

412 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 8 sec
  • test_tools: 2 min 44 sec
  • test_multiprocessing_spawn: 2 min 34 sec
  • test_peg_generator: 1 min 59 sec
  • test_multiprocessing_forkserver: 1 min 24 sec
  • test_multiprocessing_fork: 1 min 11 sec
  • test_nntplib: 1 min 6 sec
  • test_unparse: 59.8 sec
  • test_tokenize: 53.4 sec
  • test_signal: 50.5 sec

1 test altered the execution environment:
test_ftplib

14 tests skipped:
test_devpoll test_epoll test_ioctl test_kqueue test_msilib
test_nis test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 6 min 1 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_07b6354f'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_5d47d9f7'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/threading.py", line 1031, in _bootstrap_inner
    self.run()
    ^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_ftplib.py", line 294, in run
    asyncore.loop(timeout=0.1, count=1)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/support/_asyncore.py", line 208, in loop
    poll_fun(timeout, map)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/support/_asyncore.py", line 151, in poll
    read(obj)
    ^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/support/_asyncore.py", line 88, in read
    obj.handle_error()
    ^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_ftplib.py", line 136, in handle_error
    raise Exception
    ^^^^^^^^^^^^^^^
Exception


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/support/_asyncore.py", line 84, in read
    obj.handle_read_event()
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/support/_asyncore.py", line 421, in handle_read_event
    self.handle_read()
    ^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/support/_asynchat.py", line 171, in handle_read
    self.found_terminator()
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_ftplib.py", line 131, in found_terminator
    method(arg)
    ^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_ftplib.py", line 156, in cmd_pasv
    conn, addr = sock.accept()
                 ^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/socket.py", line 293, in accept
    fd, addr = self._accept()
               ^^^^^^^^^^^^^^
TimeoutError: timed out


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_98aaabcc'

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 29, 2021

Thanks, @tiran!

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran @remykarem
bpo-45020: Fix strict-prototypes warning (pythonGH-29755)
bfe9a16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon

@gvanrossum gvanrossum

@encukou encukou

@ericsnowcurrently ericsnowcurrently

@ncoghlan ncoghlan

@warsaw warsaw

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tiran @bedevere-bot @ericsnowcurrently @brettcannon @gvanrossum @the-knights-who-say-ni