-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-45828: Use unraisable exceptions within sqlite3 callbacks #29591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45828: Use unraisable exceptions within sqlite3 callbacks #29591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some nit comment what you may intended..
|
Thanks for reviewing, @corona10! |
|
@pablogsal, would you mind having a look at this? If this looks ok, I'll update GH-28240 to also use unraisable exceptions. |
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 5308680 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
I'm testing with the buildbots because adding unraisable exceptions sometimes has resulted in false-positive refleaks. If everything is ok, we can land it as it LGTM |
|
Buildbots are ok, except the Debian root bot that has problems with deepfreeze and f-strings (I though Christian fixed that issue last week). |
https://bugs.python.org/issue45828