Skip to content

bpo-45828: Use unraisable exceptions within sqlite3 callbacks #29591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 29, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 17, 2021

@erlend-aasland erlend-aasland marked this pull request as ready for review November 17, 2021 12:01
@corona10 corona10 self-requested a review November 26, 2021 14:20
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some nit comment what you may intended..

@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, @corona10!

@erlend-aasland
Copy link
Contributor Author

@pablogsal, would you mind having a look at this? If this looks ok, I'll update GH-28240 to also use unraisable exceptions.

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 28, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 5308680 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 28, 2021
@pablogsal
Copy link
Member

I'm testing with the buildbots because adding unraisable exceptions sometimes has resulted in false-positive refleaks. If everything is ok, we can land it as it LGTM

@erlend-aasland
Copy link
Contributor Author

Buildbots are ok, except the Debian root bot that has problems with deepfreeze and f-strings (I though Christian fixed that issue last week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants