New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android/application): org.nativescript.widgets.Utils::getDrawable #9563

Merged

rigor789 merged 6 commits into NativeScript:master from sebj54:patch-1

Sep 25, 2021

Contributor

sebj54 commented Sep 22, 2021 •

edited

Avoid StringIndexOutOfBoundsException in org.nativescript.widgets.Utils

As it is my first PR to this repo, I am not experimented that much with native development. Feel free to guide me so I'll now next time :)

For example, I don't know how to test this file in a NativeScript project :/

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Calling org.nativescript.widgets.Utils::getDrawable with a uri shorter than 6 characters throws a StringIndexOutOfBoundsException.

What is the new behavior?

An early check in this method ensures uri is longer than 6 characters so a warning is shown in the console.

Fixes #9562.


          fix(android/application): org.nativescript.widgets.Utils::getDrawable

f9f2675

cla-bot bot added the cla: yes label


          chore: fix spacing

7eaaa72

rigor789 reviewed

View changes

packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/Utils.java Outdated Show resolved Hide resolved

Member

rigor789 commented Sep 22, 2021

@sebj54 thanks for taking the time to do a PR - the change look good to me, I left a minor suggestion in the review.

The way you can test this requires building the widgets, which can be done by running npm start (after setting up the repo) and selecting the @nativescript/ui-mobile-base: Build for npm option - this should build the widgets lib. Then you can run any of the test apps in the repo: ui, automated or toolbox.

For this case specifically, I think a new test-case in the ui app would suffice - adding a few views and setting their background-image to a few variants like res:// res://non-existent res://icon

sebj54 and others added 2 commits


          fix(android/application): do not load empty path

afeed04

Co-authored-by: Igor Randjelovic <rigor789@gmail.com>


          test: Add tests for empty image sources

a1355f8

Contributor Author

sebj54 commented Sep 22, 2021

@rigor789 Thank you for your help! I added some views in the ui app. It runs correctly on my device but feel free to let me know if it's not exactly what was expected.

PS: The Android CI test has failed, is it expected?


          Merge branch 'master' into patch-1

711fe3f

NathanWalker reviewed

View changes


          chore: add a few more test cases

eb85d40

These make the app crash without the fix in place

rigor789 dismissed NathanWalker’s stale review via

eb85d40

rigor789 approved these changes

View changes

Member

rigor789 commented Sep 25, 2021

@sebj54 yeah, the CI has been flaky for some time now, still not sure why - it works locally...

I added a few more test-cases - the last few make the app crash without the fix, so they verify that this fixes the IndexOutOfBoundsException.

Awesome job 🎉

rigor789 merged commit 8e76bbe into NativeScript:master

2 of 3 checks passed

Contributor Author

sebj54 commented Sep 25, 2021

Thanks for the time you took to get me ready :)
So happy to have one commit in such an awesome project! 🙌

Member

rigor789 commented Sep 25, 2021

Thanks for taking the time @sebj54, hopefully sparked some interest in contributing again in the future 🎉

Contributor Author

sebj54 commented Sep 25, 2021

I hope to be able to do it soon :)

sebj54 deleted the patch-1 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment