fix(android): prevent possible crash when app goes to background #9347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core/ui/frame/index.android.ts
NathanWalker
reviewed
Apr 21, 2021
| if (this._manager && this._manager.isDestroyed()) { | ||
| // still happens with androidx.fragment:1.3.2 | ||
| const activity = androidApplication.foregroundActivity; | ||
| if ((this._manager && this._manager.isDestroyed()) || !activity.getLifecycle().getCurrentState().isAtLeast(androidx.lifecycle.Lifecycle.State.STARTED)) { |
There was a problem hiding this comment.
Do you think it’s possible that getLifecycle() or getCurrentState() could ever return null under some unexpected conditions? Might be safest to just guard those calls as well?
There was a problem hiding this comment.
They should not and I would prefer to not have the code let you believe they can.
androidx appcompatacticity have a life cycle and getCurrentState returns an enum
NathanWalker
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We faced the same issue with the material components. The old N team knew about it and try to prevent it by testing the fragment manager. However that test is not enough and we can see that we still go into
onAttachedWindowafteronStopwhile putting the app to background.This new check ensure we dont go there in that case.
It might solve some reported issues not sure.
The text was updated successfully, but these errors were encountered: