CyrusNajmabadi
Follow
CyrusNajmabadi
Follow
Pinned Loading
5,284 contributions in the last year
Less
More
Activity overview
Loading
Contribution activity
November 2021
Created 174 commits in 2 repositories
Created a pull request in dotnet/roslyn that received 37 comments
Switch go-to-impl to be entirely async/non-blocking.
Fixes AB#1419331 Fixes #41374 The prior approach to go-to-impl was: get the command from teh editor (already under a threaded wait dialog 'TWD'). p…
+727
−181
•
37
comments
Opened 35 other pull requests in 2 repositories
dotnet/roslyn
9
open
22
merged
3
closed
- Fix placement of trivia inside an interpolation
- Simplify creation of interpolation text tokens.
- Merge main into features/rawstringliterals
- Add support for interpolations in raw string literals.
- Simplify 'interpolation' data, and move to an easier to consume System.Range approach for it
- Share '$' logic with the normal lexer and the interpolated string scanner.
- Share '@'-sign logic with the normal lexer and the interpolated string scanner.
- Simplify the code around parsing interpolated string literals.
- Merge main into raw string literals
- Fix remove-unused-variable for top-level-statements
- Fix replace-prop-with-method (and the opposite) when references are in linked files.
- Search less files when searching in global suppressions.
- Simplify sqlite authoring now that we're 64bit only
- Fix add-braces crash in top-level
- Cache built skeleton assemblies so they can be reused on next launch without rebuilding them.
- Add back option to allow users to disable async lightbulbs
- Remove weakref that telemetry indicates has no impact at all.
- Fix null ref in navbars
- Ensure that getting the checksum for a project cone is resilient to its project references being missing
- Simplify code for producing project-id list
- Tweaks to the DeterministicKey PR to aid IDE scenarios
- Allow xml docs to still be created when 'emit metadata only' is on.
- Remove CWT from skeleton caching and simplify impl
- Fix issues in compilation tracker reported in prior PR
- Cleanup how we create skeleton assemblies.
- Some pull requests not shown.
jaredpar/roslyn
1
merged
Reviewed 72 pull requests in 3 repositories
dotnet/roslyn
70 pull requests
- Simplify 'interpolation' data, and move to an easier to consume System.Range approach for it
- Add support for interpolations in raw string literals.
- Fix placement of trivia inside an interpolation
- Simplify creation of interpolation text tokens.
- Share '$' logic with the normal lexer and the interpolated string scanner.
- Simplify the code around parsing interpolated string literals.
- API for getting a deterministic key for a Compilation
- Merge main to features/RawStringLiterals
- Use !! in AddParameterCheck refactoring
- Fix remove-unused-variable for top-level-statements
- Handling defaults provided by IAsyncCompletionDefaultsSource
- Fixes Introduce Parameter Replacing File Content Bug
- Switch go-to-impl to be entirely async/non-blocking.
- Handle trivia better when converting to file scoped namespaces
- Semi auto implemented properties
- Fix replace-prop-with-method (and the opposite) when references are in linked files.
- Fix curly brace and interpolated string
- Search less files when searching in global suppressions.
- Unify the namespace for our FatalError type
- [Async lightbulb performance] Move suppression fixes to 'Low' priority bucket
- Port BasicNavigationBar.CodeSpit to the new test harness
- Remove Duplicate Custom UI Visualizer Attributes from CLR Types
- Add new parser/lexer to the StackTraceAnalyzer
- Avoid eagerly running formatting or simplification for Extract Method
- Fix deadlock switching the project context dropdown
- Some pull request reviews not shown.
jaredpar/roslyn
1 pull request
dotnet/csharplang
1 pull request
Created an issue in dotnet/roslyn that received 6 comments
Navigate to original source from metadata fails to handle documentation comments
Doc comments are now interleaved with members. Causing: This is extremely hard to read, and breaks the prior MAS behavior where we would have hte …
6
comments
Opened 10 other issues in 1 repository
dotnet/roslyn
8
open
2
closed
- Crash while editing Syntax.xml
- Investigate update FAR-like features to show hits in shared-projects, not the projects the shared filed are linked into
- Should the comment TODO behavior be changed?
-
thisnot showing up in a property initializer - Deadlock in project system
- ServiceHub CoreCLR is failing to load sqlite dlls.
- new() not respecting nullable struct
- Completion for static members incorrectly references nullable static type.
- Completion in dotted property pattern incorrect for nullable value type properties
- IDE should cache source-generated docs so that they are available for subsequent sessions without recomputation.
Answered 4 discussions in 3 repositories
dotnet/csharplang
dotnet/csharplang
dotnet/roslyn
dotnet/roslyn
dotnet/runtime
dotnet/runtime