Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitignore for Microsoft Business Central #3871

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add .gitignore for Microsoft Business Central #3871

merged 1 commit into from
Dec 7, 2021

Conversation

GuillemPM
Copy link
Contributor

Reasons for making this change:

Dynamics 365 Business Central is a Microsoft solution used by thousands of companies.
We as developers have to use external services in order to get a .gitignore template which is outdated or quite simple.

Links to documentation supporting these rule changes:

https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-reference-overview
https://gitignore.io/api/AL

If this is a new template:

@bdougie bdougie added the merge conflicts This is blocked due to merge conflicts label Dec 4, 2021
@bdougie
Copy link
Contributor

bdougie commented Dec 4, 2021

Thanks for the contribution, however per the contribution guidelines this file should be placed in the community folder. Please edit the location of the file.

https://github.com/github/gitignore#specialized-templates

@bdougie bdougie added feedback given and removed merge conflicts This is blocked due to merge conflicts labels Dec 4, 2021
@bdougie bdougie mentioned this pull request Dec 4, 2021
Closed
bdougie
bdougie suggested changes Dec 4, 2021
View reviewed changes
Copy link
Contributor

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move to the community folder

@JeremyVyska
Copy link

For what it's worth, this version is much better than #2743 for general use.

@bdougie - question for you, if you'd be so kind: The reason folks are trying to support AL language gitignore files is because that will add them to the "Add a .gitignore file" dropdown. I notice that the community folder ones are not in that list. Is there a smart way that one could create new AL repos using the gitignore from the community folder?

@GuillemPM
Copy link
Contributor Author

For what it's worth, this version is much better than #2743 for general use.

@bdougie - question for you, if you'd be so kind: The reason folks are trying to support AL language gitignore files is because that will add them to the "Add a .gitignore file" dropdown. I notice that the community folder ones are not in that list. Is there a smart way that one could create new AL repos using the gitignore from the community folder?

I agree with @JeremyVyska as AL is a language that repositories are totally based on. If it's possible we would like to have direct access to the template in Add .gitignore at repository creation time

@bdougie
Copy link
Contributor

bdougie commented Dec 7, 2021

@JeremyVyska thanks for the input and the context @GuillemPM. I will go ahead and merge as-is.

@bdougie bdougie merged commit 2b8e5b3 into github:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdougie bdougie bdougie approved these changes

Assignees
No one assigned
Labels
feedback given
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillemPM @bdougie @JeremyVyska @moucheron52