Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Idea: Convert octo-sidebar-item from <div> to <button> #1513

Open
asaadmahmood opened this issue Oct 11, 2021 · 5 comments
Open

Feature Idea: Convert octo-sidebar-item from <div> to <button> #1513

asaadmahmood opened this issue Oct 11, 2021 · 5 comments
Assignees
@anirudhprabhakaran3
Labels
Enhancement Good First Issue Hacktoberfest Help Wanted

Comments

@asaadmahmood
Copy link
Contributor

@asaadmahmood asaadmahmood commented Oct 11, 2021

Summary

Feature Idea: Convert octo-sidebar-item from

to

How important this is to me and why

Importance: Medium

Additional context/similar features

This is being used multiple times in the file, so please be sure to replace all instances.
Also, some css changes may be needed to revert the button base styles that are applied, so the UI looks the same as before.

Screenshot 2021-10-11 at 8 16 36 PM
@asaadmahmood asaadmahmood mentioned this issue Oct 11, 2021
Closed
@anirudhprabhakaran3
Copy link

@anirudhprabhakaran3 anirudhprabhakaran3 commented Oct 12, 2021

Hey, I would love to work on this issue!

Loading

@asaadmahmood
Copy link
Contributor Author

@asaadmahmood asaadmahmood commented Oct 12, 2021

Cool. @anirudhprabhakaran3 Its yours.

Loading

@anirudhprabhakaran3
Copy link

@anirudhprabhakaran3 anirudhprabhakaran3 commented Oct 13, 2021

Okay, i think this is a very beginner doubt, but any change that I am actually making the react code is not showing up on the web app. Am I missing something?

Loading

@asaadmahmood
Copy link
Contributor Author

@asaadmahmood asaadmahmood commented Oct 13, 2021

@anirudhprabhakaran3 Have you run the watch command?

Loading

@anirudhprabhakaran3
Copy link

@anirudhprabhakaran3 anirudhprabhakaran3 commented Oct 13, 2021

Oh yes, I had forgotten to run that. I was just running the server. Thank you!

Loading

@anirudhprabhakaran3 anirudhprabhakaran3 mentioned this issue Oct 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anirudhprabhakaran3 anirudhprabhakaran3

Labels
Enhancement Good First Issue Hacktoberfest Help Wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@asaadmahmood @anirudhprabhakaran3