Skip to content

bpo-45846: Fix capitalisation of Van Rossum in Doc/faq/programming.rst#29641

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
irismessage:bpo-45846-docs-typo-fix
Nov 20, 2021
Merged

bpo-45846: Fix capitalisation of Van Rossum in Doc/faq/programming.rst#29641
serhiy-storchaka merged 1 commit into
python:mainfrom
irismessage:bpo-45846-docs-typo-fix

Conversation

@irismessage
Copy link
Copy Markdown
Contributor

@irismessage irismessage commented Nov 19, 2021 •
edited by bedevere-bot
Loading

References:

Issue:
https://bugs.python.org/issue45846

I know this is a trivial typo fix but I made an issue for it because I was making two other issues and because I'm a first time contributor.

https://bugs.python.org/issue45846

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Nov 19, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@JMcB17

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 19, 2021
@irismessage
Copy link
Copy Markdown
Contributor Author

irismessage commented Nov 19, 2021

I signed the thing. I'll wait for it to go through

@ericvsmith
Copy link
Copy Markdown
Member

ericvsmith commented Nov 19, 2021

I think this is trivial enough to not need the CLA, but it's a good idea to wait for it, anyway.

You should probably get an okay from @gvanrossum, in case his mind has changed on this. I don't know if this particular sentence is deliberate or not.

@ericvsmith ericvsmith self-assigned this Nov 19, 2021
@Fidget-Spinner Fidget-Spinner mentioned this pull request Nov 20, 2021
Closed
@serhiy-storchaka serhiy-storchaka merged commit bc2bc0d into python:main Nov 20, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 20, 2021

Thanks @JMcB17 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 20, 2021

GH-29656 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 20, 2021
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 20, 2021

GH-29657 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2021
@irismessage @miss-islington
bpo-45846: Fix capitalisation of Van Rossum at the start of sentence (p…
a06c508 
…ythonGH-29641)

(cherry picked from commit bc2bc0d)

Co-authored-by: JMcB <joel.mcbride1@live.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2021
@irismessage @miss-islington
bpo-45846: Fix capitalisation of Van Rossum at the start of sentence (p…
0251ab1 
…ythonGH-29641)

(cherry picked from commit bc2bc0d)

Co-authored-by: JMcB <joel.mcbride1@live.com>
ambv pushed a commit that referenced this pull request Nov 20, 2021
@miss-islington @irismessage
bpo-45846: Fix capitalisation of Van Rossum at the start of sentence (G…
82f1a6e 
…H-29641) (GH-29656)

(cherry picked from commit bc2bc0d)

Co-authored-by: JMcB <joel.mcbride1@live.com>
ambv pushed a commit that referenced this pull request Nov 20, 2021
@miss-islington @irismessage
bpo-45846: Fix capitalisation of Van Rossum at the start of sentence (G…
e88f978 
…H-29641) (GH-29657)

(cherry picked from commit bc2bc0d)

Co-authored-by: JMcB <joel.mcbride1@live.com>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@irismessage @remykarem
bpo-45846: Fix capitalisation of Van Rossum at the start of sentence (p…
b8e83ad 
…ythonGH-29641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@ericvsmith ericvsmith

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@irismessage @the-knights-who-say-ni @ericvsmith @miss-islington @bedevere-bot @gvanrossum @serhiy-storchaka @terryjreedy