Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Inconsistency in the field title of the property pane #8439

Open
1 task done
YogeshJayaseelan opened this issue Oct 12, 2021 · 7 comments · May be fixed by #8599
Open
1 task done

[Bug]: Inconsistency in the field title of the property pane #8439

YogeshJayaseelan opened this issue Oct 12, 2021 · 7 comments · May be fixed by #8599
Assignees
@AR10X
Labels
Bug Good First Issue hacktoberfest Low Papercut Production UX Improvement

Comments

Assignees

@AR10X AR10X

Labels
Bug Good First Issue hacktoberfest Low Papercut Production UX Improvement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix: [Bug]: Inconsistency in the field title of the property pane #8439
3 participants
@somangshu @YogeshJayaseelan @AR10X
@YogeshJayaseelan
Copy link
Contributor

@YogeshJayaseelan YogeshJayaseelan commented Oct 12, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

For few of the Widgets the text title is displayed as colour in some places and color in some places.

Current status:

1.Container widget - Background colour, Border colour and Shadow color
2.Audio Recorder - Icon color , Background color
3.Button Widget - Button color, Shadow color
4.Divider Widget - Divider color
5.Form Widget - Background colour, Border colour and Shadow color
6.Icon Widget - Button color, Shadow color
7.Iframe Widget - Border color
8.List Widget - Background , Item Background - text colour is not displayed
9.Menu Widget - Icon color, Text color, Background color , Menu color, Shadow color
10.MultiTeeSelect - Label text color
12.Rate Widget - Active color, Inactive color
13.Stat Box Widget - Background color
14.Table Widget - Cell Background -text colour is not displayed for Cell Background , Text color
15.Text Widget - Cell Background -text colour is not displayed for Cell Background , Text color , Border Colour
16.TreeSelect - Label text color

Steps To Reproduce

1.Launch appsmith app in release or Prod environment 
2.Drag and drop most of the widgets , open property pane and check the field title of colour

Environment

Production

Version

Cloud
@AR10X
Copy link
Contributor

@AR10X AR10X commented Oct 12, 2021

I would like to work on this, I am working on similar issues #8436 & #8306

@YogeshJayaseelan YogeshJayaseelan mentioned this issue Oct 12, 2021
Open
1 task
@AR10X
Copy link
Contributor

@AR10X AR10X commented Oct 12, 2021

What should be the right fix, should all of these display as Colour or Color?

@somangshu
Copy link
Contributor

@somangshu somangshu commented Oct 12, 2021

@AR10X looking into this, Once I get this cleared out, Shall let you know and assign you

@somangshu
Copy link
Contributor

@somangshu somangshu commented Oct 12, 2021

@AR10X This is all your. Assigning this to you now. The change will be:

  • We follow US english and hence we will use Color everywhere, In other words replace Colour(s) to Color(s)

@somangshu somangshu assigned AR10X and unassigned somangshu Oct 12, 2021
@AR10X
Copy link
Contributor

@AR10X AR10X commented Oct 12, 2021

@somangshu Ok noted. 👍

@AR10X
Copy link
Contributor

@AR10X AR10X commented Oct 13, 2021 •
edited

I have made the following changes:
Changing colour to color for following widget, rest of the widget already having color hasn't been changed.

1.Container widget - Background colour, Border colour and Shadow color ✔️

5.Form Widget - Background colour, Border colour and Shadow color ❗
(couldn't find any files in form widget having the above properties)

8.List Widget - Background , Item Background - text colour is not displayed ✔️

14.Table Widget - Cell Background -text colour is not displayed for Cell Background , Text color ❗
(couldn't find any files in table widget having the above properties)

15.Text Widget - Cell Background -text colour is not displayed for Cell Background , Text color , Border Colour ✔️

@somangshu
Copy link
Contributor

@somangshu somangshu commented Oct 18, 2021

@AR10X please link the PR to this issue so that the reviewer has a better context

AR10X added a commit to AR10X/appsmith that referenced this issue Oct 18, 2021
@AR10X
issue appsmithorg#8439
a978a58
@AR10X AR10X linked a pull request that will close this issue Oct 18, 2021
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment