Ruby/Python: parse anchors in regexes as special characters#7120
Merged
Ruby/Python: parse anchors in regexes as special characters#7120
Conversation
Contributor
Author
|
Yes, probably. I'll check on that once #6561 is merged. |
nickrolfe
force-pushed
the
nickrolfe/regexp_g_anchor
branch
from
ddaea93 to
df6ba43
Compare
nickrolfe
changed the title
Contributor
Author
|
I've updated this to handle I've also changed Python to handle These changes should fix ReDoS FPs such as this one in I should probably add that Ruby FP as a test case, but I'm not sure how to handle the licensing. cc @erik-krogh @yoff |
yoff
previously approved these changes
Dec 2, 2021
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
Great work, thanks for also fixing the Python side (including tests and all)!
Contributor
Author
|
Thanks! There were merge conflicts in the Ruby ReDoS test – now resolved. |
alexrford
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/codeql-team/issues/599
It means the ReDoS query no longer suggests an example input starting with 'G'.