Skip to content

C#: PrimaryQlClass#7118

Merged
michaelnebel merged 6 commits into
github:mainfrom
michaelnebel:csharp-primary-ql-class
Jan 14, 2022
Merged

C#: PrimaryQlClass#7118
michaelnebel merged 6 commits into
github:mainfrom
michaelnebel:csharp-primary-ql-class

Conversation

@michaelnebel

@michaelnebel michaelnebel commented Nov 12, 2021

Copy link
Copy Markdown
Contributor
  • Introduce a consistency query for getAPrimaryQlClass on each element
  • Add overrides for getAPrimaryQlClass for all elements in source files, where "???" was printed as primary ql class.

@michaelnebel michaelnebel requested a review from hvitved November 12, 2021 09:08
@michaelnebel michaelnebel requested a review from a team as a code owner November 12, 2021 09:08
@github-actions github-actions Bot added the C# label Nov 12, 2021
@michaelnebel michaelnebel marked this pull request as draft November 12, 2021 09:25
@michaelnebel michaelnebel force-pushed the csharp-primary-ql-class branch from b2dd800 to a67327e Compare November 16, 2021 13:53
@michaelnebel michaelnebel force-pushed the csharp-primary-ql-class branch from a67327e to 85fc127 Compare January 13, 2022 11:50
@michaelnebel michaelnebel marked this pull request as ready for review January 13, 2022 14:25
Comment thread csharp/ql/consistency-queries/PrimaryQlClass.ql Outdated
Comment thread csharp/ql/lib/semmle/code/csharp/Generics.qll Outdated
@michaelnebel michaelnebel requested a review from hvitved January 14, 2022 11:00
@michaelnebel michaelnebel merged commit e09009c into github:main Jan 14, 2022
@michaelnebel michaelnebel deleted the csharp-primary-ql-class branch January 14, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants