Python: Fix some query-ids#7101
Merged
Merged
Conversation
The two queries in CWE-020 are used for manual evaluation (is my understanding), and the two IDE queries should work based on their tags, and not on the query-id.
aeisenberg
previously approved these changes
Nov 10, 2021
aeisenberg
left a comment
aeisenberg
left a comment
Contributor
There was a problem hiding this comment.
Yep. This looks good to me. The id is not used, only the tag(s).
Member
Author
I got a signoff from @GeekMasher instead, so we are all good to merge it 👍 |
Member
Author
|
I'll write a change-note for this |
Member
Author
|
Great, that means all parties involved have given 👍 now, so I will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two queries in CWE-020 are used for manual evaluation (is my
understanding), and the two IDE queries should work based on their tags,
and not on the query-id.
We should get a sign-off on both of them just to be sure though.
idfor the External APIs queries is not going to be a problem?Thanks 😊