Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make comment structure consistent in packages/core/index.ts, fix minor grammar mistakes in documentation #43684

Closed
wants to merge 3 commits into from
+9 −8
Closed

refactor: make comment structure consistent in packages/core/index.ts, fix minor grammar mistakes in documentation #43684

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
579a526
docs: fixed minor grammar mistakes in CONTRIBUTING
import-brain Oct 2, 2021
45c3470
docs: added commas to sentences in .vscode/README.md
import-brain Oct 2, 2021
cc86ac0
refactor(core): made comment structure consistent in index.ts
import-brain Oct 2, 2021
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 .vscode/README.md
View file
Open in desktop
@@ -12,9 +12,9 @@ To use the recommended configurations follow the steps below:
- copy (or link) `.vscode/recommended-tasks.json` to `.vscode/tasks.json`
- restart the editor

If you already have your custom workspace settings you should instead manually merge the file contents.
If you already have your custom workspace settings, you should instead manually merge the file contents.

This isn't an automatic process so you will need to repeat it when settings are updated.
This isn't an automatic process, so you will need to repeat it when settings are updated.

To see the recommended extensions select "Extensions: Show Recommended Extensions" in the [Command Palette](https://code.visualstudio.com/docs/getstarted/userinterface#_command-palette).

4 CONTRIBUTING.md
View file
Open in desktop
@@ -58,9 +58,9 @@ If you would like to *implement* a new feature, please consider the size of the

### <a name="submit-issue"></a> Submitting an Issue

Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.
Before you submit an issue, please search the issue tracker. An issue for your problem might already exist and the discussion might inform you of workarounds readily available.

We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it.
We want to fix all the issues as soon as possible, but before fixing a bug, we need to reproduce and confirm it.
In order to reproduce bugs, we require that you provide a minimal reproduction.
Having a minimal reproducible scenario gives us a wealth of important information without going back and forth to you with additional questions.

9 packages/core/index.ts
View file
Open in desktop
@@ -6,9 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/

// This file is not used to build this module. It is only used during editing
// by the TypeScript language service and during build for verification. `ngc`
// replaces this file with production index.ts when it rewrites private symbol
// names.
/* This file is not used to build this module. It is only used during editing
* by the TypeScript language service and during build for verification. `ngc`
* replaces this file with production index.ts when it rewrites private symbol
* names.
*/

export * from './public_api';