docs: Adding type annotation to ngOnInit()#43579
Conversation
|
@fusho-takahashi thanks for creating the PR. I'm curious what is the main motivation of adding those types? Is that mostly for consistency purposes with other methods on those classes? Thank you. |
|
@AndrewKushnir Thank you for your comment. |
|
@fusho-takahashi thanks for additional information. Could you please let me know which CLI commands you've used (so I can reproduce the problem)? Thank you. |
|
@AndrewKushnir |
AndrewKushnir
left a comment
There was a problem hiding this comment.
@fusho-takahashi thanks for additional information. The change looks good 👍
Could you please update the commit message to include a note on why this change is made (to make it consistent with the class structure produced by the CLI)?
Thank you.
3e15eca to
9b5dc5d
Compare
1�7 the class structure produced by the CLI
9b5dc5d to
265c8d3
Compare
|
This PR was merged into the repository by commit 6c618de. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |


Adding type annotation to ngOnInit() in example codes of tutorial.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Adding type annotation to ngOnInit() in example codes of tutorial.
ref. https://github.com/angular/angular-cli/blob/a02f48d6f82d7568b4f5bc26add4f7bfa36e2d3f/packages/schematics/angular/component/files/__name%40dasherize%40if-flat__/__name%40dasherize__.__type%40dasherize__.ts.template#L26
Does this PR introduce a breaking change?