refactor(forms): inherit ngOnChanges hooks from the base class
#43945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
force-pushed
the
abstract_validator_dir_refactor
branch
from
6dc8197
to
17a3b69
This commit updates the code of the min/max and minlength/maxlength validator directives to inherit `ngOnChanges` hooks from the base class (the `AbstractValidatorDirective` one), rather than implementing the hooks on the child classes. This was needed to avoid issues with hooks inheritance in ViewEngine, but since it's deprecated, the code can be cleaned up.
AndrewKushnir
force-pushed
the
abstract_validator_dir_refactor
branch
from
17a3b69
to
d3ca679
AndrewKushnir
added
action: review
target: patch
and removed
state: WIP
target: minor
labels
atscott
approved these changes
Nov 16, 2021
|
This PR was merged into the repository by commit 65597d6. |
AndrewKushnir
added a commit
that referenced
this issue
Nov 17, 2021
) This commit updates the code of the min/max and minlength/maxlength validator directives to inherit `ngOnChanges` hooks from the base class (the `AbstractValidatorDirective` one), rather than implementing the hooks on the child classes. This was needed to avoid issues with hooks inheritance in ViewEngine, but since it's deprecated, the code can be cleaned up. PR Close #43945
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
dimakuba
added a commit
to dimakuba/angular
that referenced
this issue
Dec 28, 2021
…ular#43945) This commit updates the code of the min/max and minlength/maxlength validator directives to inherit `ngOnChanges` hooks from the base class (the `AbstractValidatorDirective` one), rather than implementing the hooks on the child classes. This was needed to avoid issues with hooks inheritance in ViewEngine, but since it's deprecated, the code can be cleaned up. PR Close angular#43945
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This commit updates the code of the min and max validator directives to inherit
ngOnChangeshooks from the base class (theAbstractValidatorDirectiveone), rather than implementing the hooks on the child classes. This was needed to avoid issues with hooks inheritance in ViewEngine, but since it's deprecated, the code can be cleaned up.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The text was updated successfully, but these errors were encountered: