Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -AsNupkg and -IncludeXML params and test #538

Merged
merged 10 commits into from Dec 1, 2021

Conversation

@alerickson
Copy link
Member

@alerickson alerickson commented Nov 9, 2021

PR Summary

Added -AsNupkg and -IncludeXML to completed the parameters for Save-PSResource.

PR Context

Resolves #470

PR Checklist

@alerickson alerickson requested review from PaulHigin and anamnavi Nov 9, 2021
src/code/InstallHelper.cs Show resolved Hide resolved
Loading
@alerickson alerickson requested a review from PaulHigin Nov 30, 2021
Copy link
Collaborator

@PaulHigin PaulHigin left a comment

Looks good, but I did spot two unused fields (see related comment). Please remove them before merging.

Loading

src/code/InstallHelper.cs Show resolved Hide resolved
Loading
@alerickson alerickson merged commit d605294 into PowerShell:master Dec 1, 2021
10 checks passed
Loading
@alerickson alerickson deleted the saveParams branch Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants