Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Windows support for tsec_test. #44130

Closed
wants to merge 1 commit into from
Closed

ci: Windows support for tsec_test. #44130

wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Nov 10, 2021

cherry-pick to patch branch of #43924
@uraj @atscott
ci: Windows support for tsec_test.
5d4cee1 
Contents of generated tsconfig for tsec_test now depend on whether
Bazel uses symlinked runfiles for nodejs_test. The current
implementation assumes that symlinked runfiles are not available
on Windows.
@google-cla google-cla bot added the cla: yes label Nov 10, 2021
@pullapprove pullapprove bot requested review from IgorMinar and jelbourn Nov 10, 2021
@google-cla google-cla bot added the cla: yes label Nov 10, 2021
@atscott atscott mentioned this pull request Nov 10, 2021
Closed
14 tasks
IgorMinar
IgorMinar approved these changes Nov 10, 2021
View changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

LGTM! Thank you!

note: cherry-pick

Reviewed-for: global-approvers

@IgorMinar IgorMinar removed the request for review from jelbourn Nov 10, 2021
@atscott
Copy link
Contributor Author

@atscott atscott commented Nov 10, 2021

This PR was merged into the repository by commit bfb2882.

@atscott atscott closed this Nov 10, 2021
atscott added a commit that referenced this issue Nov 10, 2021
@uraj @atscott
ci: Windows support for tsec_test. (#44130)
bfb2882 
Contents of generated tsconfig for tsec_test now depend on whether
Bazel uses symlinked runfiles for nodejs_test. The current
implementation assumes that symlinked runfiles are not available
on Windows.

PR Close #44130
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Dec 11, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar

Assignees
No one assigned
Labels
action: merge cla: yes target: patch
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@atscott @IgorMinar @uraj