Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve issue template using Issue forms #2684

Merged
merged 10 commits into from Nov 8, 2021

Conversation

Andre601
Copy link
Contributor

@Andre601 Andre601 commented Nov 2, 2021

Replaces the current ISSUE_TEMPLATE.md with a more advanced (and better looking) Issue form.
Additionally adds some common links such as wiki, Discord server, etc. which will be shown when you select the issue template.

A preview of the new issue template can be seen on my fork:
https://github.com/Andre601/Citizens2/blob/feature/add-issue-forms/.github/ISSUE_TEMPLATE/bug_report.yml

@mcmonkey4eva
Copy link
Member

@mcmonkey4eva mcmonkey4eva commented Nov 4, 2021

Definitely an improvement over the old template text file system.

Listed a few couple minor corrections to your PR in comments above, and while thinking about the issue template at all, realized a few things were outdated, figured I'd just leave them as comments here.

If you prefer, I can use the magic github edit-other-peoples-PRs button that apparently exists to apply my suggested changes myself.

EDIT: Also a Feature Request template would be good to have as well

@Andre601
Copy link
Contributor Author

@Andre601 Andre601 commented Nov 4, 2021

EDIT: Also a Feature Request template would be good to have as well

Sure thing. Just need to know what sections you want and what type they should be.
Full syntax for issue forms is here: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms

Andre601 added 3 commits Nov 4, 2021
- Update Paste URL
- Make sharing of saves.yml required
- Change URL for Spark download
- Fix typo for "reproduce"
- Allow blank (empty) issues
- Replace warning about dev builds with note to make backups.
@Andre601
Copy link
Contributor Author

@Andre601 Andre601 commented Nov 4, 2021

I've created a Feature request form which you can find here

Right now does it have checkboxes you have to tick, a text field to give a description of the idea and an optional text field for possible code.
I was considering to add a Dropdown to let the user choose if the feature is for the plugin and/or the API, but not sure about that.

attributes:
label: 'Code Example'
description: |-
If possible, provide a possible Code example for how this could be implemented, or in case of a new API feature, how others could use it.
Copy link
Member

@fullwall fullwall Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bit too technical for all feature requests. Maybe word it to be more optional?

label: 'I confirm that I have ...'
description: 'Click the checkboxes to "check" them. Make sure you actually did what they mention.'
options:
- label: '...tried the latest [Development Build](https://wiki.citizensnpcs.co/API) to make sure my feature doesn''t exist already.'
Copy link
Member

@mcmonkey4eva mcmonkey4eva Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the intended link was https://ci.citizensnpcs.co/job/Citizens2/ not the API wiki page?

@fullwall fullwall merged commit e7d3a95 into CitizensDev:master Nov 8, 2021
1 check passed
@fullwall
Copy link
Member

@fullwall fullwall commented Nov 8, 2021

Thanks!

@Andre601 Andre601 deleted the feature/add-issue-forms branch Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants