Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata.json in preparation on 7.3.0-preview.1 release #16406

Merged
merged 2 commits into from Nov 9, 2021
Merged

Update metadata.json in preparation on 7.3.0-preview.1 release #16406

merged 2 commits into from Nov 9, 2021

Conversation

Reviewers

@PaulHigin PaulHigin

@iSazonov iSazonov

@anmenaga anmenaga

@daxian-dbw daxian-dbw

@TravisEz13 TravisEz13

Assignees

@PaulHigin PaulHigin

Labels
Extra Small
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@adityapatwardhan @PaulHigin @iSazonov
@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Nov 9, 2021 •
edited
Loading

PR Summary

Update the metadata so dev build will pickup the correct version.

PR Context

Similar changes done for 7.1 -> 7.2 #14026

PR Checklist
@adityapatwardhan
Update metadata.json in preparation on 7.3.0-preview.1 release
602369f
PaulHigin
PaulHigin approved these changes Nov 9, 2021
View changes
Copy link
Collaborator

@PaulHigin PaulHigin left a comment

LGTM

Loading

@adityapatwardhan
Update PSVersion table and tests
fb30a58
@pull-request-quantifier
Copy link

@pull-request-quantifier pull-request-quantifier bot commented Nov 9, 2021

This PR has 9 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +5 -4
Percentile : 3.6%

Total files changed: 4

Change summary by file extension:
.cs : +2 -1
.ps1 : +2 -2
.json : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

Loading

@adityapatwardhan
Copy link
Member Author

@adityapatwardhan adityapatwardhan commented Nov 9, 2021

@PaulHigin Please re-review.. some changes with new commit.

Loading

iSazonov
iSazonov approved these changes Nov 9, 2021
View changes
src/System.Management.Automation/engine/PSVersionInfo.cs
@@ -64,6 +64,7 @@ public static class PSVersionInfo
private static readonly SemanticVersion s_psV62Version = new SemanticVersion(6, 2, 0, preReleaseLabel: null, buildLabel: null);
private static readonly SemanticVersion s_psV7Version = new SemanticVersion(7, 0, 0, preReleaseLabel: null, buildLabel: null);
private static readonly SemanticVersion s_psV71Version = new SemanticVersion(7, 1, 0, preReleaseLabel: null, buildLabel: null);
private static readonly SemanticVersion s_psV72Version = new SemanticVersion(7, 2, 0, preReleaseLabel: null, buildLabel: null);
Copy link
Collaborator

@iSazonov iSazonov Nov 9, 2021

Nit: I wonder we keep old and unsupported versions here

Loading

Copy link
Member Author

@adityapatwardhan adityapatwardhan Nov 9, 2021

@PaulHigin is the PSCompatibleEdition needed for remoting?
@PowerShell/powershell-maintainers -- what do you think? Should 6.2.0 be removed?

Loading

Copy link
Collaborator

@PaulHigin PaulHigin Nov 9, 2021

Not that I am aware of.

Loading

@PaulHigin PaulHigin merged commit f8d6b2f into PowerShell:master Nov 9, 2021
36 checks passed
Loading
@PaulHigin PaulHigin deleted the Prepare73p1 branch Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment