-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix tab completion for attribute ScriptBlocks. #14550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tab completion for attribute ScriptBlocks. #14550
Conversation
src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
It seems like this PR has been forgotten. Any chance it can be added before its first birthday? |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@MartinGC94 Thanks for your contribution! |
…eScriptAttribute`. (PowerShell#14550)
|
🎉 Handy links: |
…eScriptAttribute`. (PowerShell#14550)
PR Summary
This fixes the issue where trying to tab complete commands, command parameters, etc. inside a ValidateScript ScriptBlock would always complete to the attribute parameters for ValidateScript.
For example:
[ValidateScript({get-chil<Tab>})]$idk=lswould result in[ValidateScript({ErrorMessage})]$idk=lsPR Context
Tab completion is an important feature that should give useful results whenever possible.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.