Skip to content

Conversation

MartinGC94
Copy link
Contributor

PR Summary

This fixes the issue where trying to tab complete commands, command parameters, etc. inside a ValidateScript ScriptBlock would always complete to the attribute parameters for ValidateScript.
For example: [ValidateScript({get-chil<Tab>})]$idk=ls would result in [ValidateScript({ErrorMessage})]$idk=ls

PR Context

Tab completion is an important feature that should give useful results whenever possible.

PR Checklist

@ghost ghost assigned TravisEz13 Jan 6, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 6, 2021
Co-authored-by: Ilya <darpa@yandex.ru>
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 13, 2021
@ghost
Copy link

ghost commented Jan 13, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@MartinGC94
Copy link
Contributor Author

It seems like this PR has been forgotten. Any chance it can be added before its first birthday?

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 4, 2021
@iSazonov iSazonov closed this Nov 4, 2021
@iSazonov iSazonov reopened this Nov 4, 2021
@pull-request-quantifier-deprecated

This PR has 12 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +10 -2
Percentile : 4.8%

Total files changed: 2

Change summary by file extension:
.cs : +4 -2
.ps1 : +6 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw merged commit 965dc8f into PowerShell:master Nov 10, 2021
@iSazonov
Copy link
Collaborator

@MartinGC94 Thanks for your contribution!

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Nov 11, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@MartinGC94 MartinGC94 deleted the FixAttributeScriptBlockCompletion branch June 5, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants