Merged
Conversation
Contributor
|
Thanks for the ping! I think @yoff may be better situated to weigh in on the Python side of things. (If not, I'll do my own investigations when time permits.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this snippet:
With the existing formulation of
basicStoreStep, we would track flow from"hello"intoself.fieldin the setter, because the target of the store was the pre-update node and not the post-update node. However, we actually didn't have any flow, sincebasicStoreStepwas erroneously restricted to target only local source nodes. The second commit introduces the false flow (and the correct missing flow) by removing the local-source-node restriction, and the last commit removes the false flow by targeting post-update nodes.@tausbn : AFAICT, the Python implementation also doesn't use post-update nodes, but perhaps there it is not a problem, if the pre-update node may not flow into a call like above.