Skip to content

Make the last step a step in Mirroring a repo sect#11564

Merged
lecoursen merged 3 commits into
github:mainfrom
jacola:patch-2
Nov 12, 2021
Merged

Make the last step a step in Mirroring a repo sect#11564
lecoursen merged 3 commits into
github:mainfrom
jacola:patch-2

Conversation

@jacola
Copy link
Copy Markdown
Member

@jacola jacola commented Oct 31, 2021 •
edited
Loading

To make it more clear that the final push is required, it might be better to number that step as well. Combined with the extra? line break between the terminal commands in step 3 and "As with a bare clone..." it was confusing at first glance.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@jacola
Make the last step a step in Mirroring a repo sect
7bf888e 
To make it more clear that the final push is required, it might be better to number that step as well. Combined with the extra? line break between the terminal commands in step 3 and "As with a bare clone..." it was confusing at first glance.
@welcome
Copy link
Copy Markdown

welcome Bot commented Oct 31, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Oct 31, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 31, 2021 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/repositories/creating-and-managing-repositories/duplicating-a-repository.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 1, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Nov 1, 2021

@jacola
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 3, 2021
lecoursen
lecoursen approved these changes Nov 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jacola, thanks!

@lecoursen lecoursen enabled auto-merge November 12, 2021 20:44
@lecoursen lecoursen merged commit 1779cb7 into github:main Nov 12, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 12, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacola @ramyaparimi @lecoursen @rsese