Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34605, libregrtest: Avoid master/slave terms #9099

Merged
merged 1 commit into from Sep 7, 2018
Merged

bpo-34605, libregrtest: Avoid master/slave terms #9099

merged 1 commit into from Sep 7, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
8 participants
@vstinner @rsaleri @and3rson @NiKiZe @Marcon @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
@vstinner
Copy link
Member

@vstinner vstinner commented Sep 7, 2018 •
edited by bedevere-bot

  • Rename --slaveargs to --worker-args
  • Rename run_tests_slave() to run_tests_worker()

https://bugs.python.org/issue34605
@vstinner
bpo-34605, libregrtest: Avoid master/slave terms
f37fea7 
* Rename --slaveargs to --worker-args
* Rename run_tests_slave() to run_tests_worker()
@vstinner vstinner merged commit 012f5b9 into python:master Sep 7, 2018
9 checks passed
@vstinner vstinner deleted the regrtest_master_slave branch Sep 7, 2018
lisroach added a commit to lisroach/cpython that referenced this issue Sep 12, 2018
@vstinner @lisroach
bpo-34605, libregrtest: Rename --slaveargs to --worker-args (pythonGH…
c44fcb4 
…-9099)

Rename also run_tests_slave() to run_tests_worker().
@rsaleri

This comment was marked as off-topic.

Sign in to view
@and3rson

This comment was marked as off-topic.

Sign in to view
@NiKiZe

This comment was marked as off-topic.

Sign in to view
@Marcon

This comment was marked as disruptive content.

Sign in to view
@python python locked and limited conversation to collaborators Sep 13, 2018
@python python deleted a comment from pkarolyi Sep 13, 2018
@python python deleted a comment from babadoctor Sep 13, 2018
@python python deleted a comment from rsaleri Sep 13, 2018
@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 14, 2018

This one LGTM. This is our internal API, and there are no any relations with existing common terminology. I always wondered why such bizarre name was used here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.