Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify getAuthTag with authTagLength #40713

Closed
wants to merge 1 commit into from
Closed

doc: clarify getAuthTag with authTagLength #40713

wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Nov 3, 2021

This behavior is only documented in createCipheriv and createCipher, but should also be mentioned in getAuthTag.

Refs: #40272
Refs: #20235
Trott
Trott approved these changes Nov 3, 2021
View changes
panva
panva approved these changes Nov 3, 2021
View changes
lpinca
lpinca approved these changes Nov 3, 2021
View changes
@tniessen
Copy link
Member Author

@tniessen tniessen commented Nov 8, 2021

I'm not sure what's going on with the commit queue.

Loading

@targos
Copy link
Member

@targos targos commented Nov 8, 2021

The commit queue is blocked on nodejs/admin#640

Loading

@targos
Copy link
Member

@targos targos commented Nov 9, 2021

Landed in dd60161

Loading

targos added a commit that referenced this issue Nov 9, 2021
@tniessen @targos
doc: clarify getAuthTag with authTagLength
dd60161 
Refs: #40272
Refs: #20235

PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos closed this Nov 9, 2021
targos added a commit that referenced this issue Nov 21, 2021
@tniessen @targos
doc: clarify getAuthTag with authTagLength
20d7d65 
Refs: #40272
Refs: #20235

PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva

@Trott Trott

@lpinca lpinca

Assignees
No one assigned
Labels
commit-queue crypto doc
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@tniessen @targos @panva @Trott @lpinca @nodejs-github-bot