src,crypto: refactor crypto_tls.*
#40675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been hidden.
This comment has been hidden.
38 tasks
RaisinTen
force-pushed
the
src,crypto/refactor-crypto_tls
branch
4 times, most recently
from
73bce22
to
261229d
35 tasks
addaleax
approved these changes
Nov 2, 2021
By the design of `GetSSLError()`, the V8 API was unnecessarily being accessed in places where it eventually didn't get used. So this refactor inlines the function appropriately in places where it was being used. Also, this replaces uses of `AllocatedBuffers` with `BackingStore`s. Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src,crypto/refactor-crypto_tls
branch
from
261229d
to
2ab44e9
This comment has been hidden.
This comment has been hidden.
42 tasks
This comment has been hidden.
This comment has been hidden.
44 tasks
43 tasks
44 tasks
46 tasks
Commit Queue failed- Loading data for nodejs/node/pull/40675 ✔ Done loading data for nodejs/node/pull/40675 ----------------------------------- PR info ------------------------------------ Title src,crypto: refactor `crypto_tls.*` (#40675) Author Darshan Sen (@RaisinTen) Branch RaisinTen:src,crypto/refactor-crypto_tls -> nodejs:master Labels crypto, c++, author ready Commits 1 - src,crypto: refactor `crypto_tls.*` Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/40675 Reviewed-By: Anna Henningsen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40675 Reviewed-By: Anna Henningsen -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 31 Oct 2021 15:15:39 GMT ✔ Approvals: 1 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/40675#pullrequestreview-795054510 ✖ This PR needs to wait 6 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-11-03T13:44:50Z: https://ci.nodejs.org/job/node-test-pull-request/40684/ - Querying data for job/node-test-pull-request/40684/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1431079248 |
46 tasks
|
Landed in 8ee9e1a |
targos
added a commit
that referenced
this issue
Nov 21, 2021
By the design of `GetSSLError()`, the V8 API was unnecessarily being accessed in places where it eventually didn't get used. So this refactor inlines the function appropriately in places where it was being used. Also, this replaces uses of `AllocatedBuffers` with `BackingStore`s. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40675 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
By the design of
GetSSLError(), the V8 API was unnecessarily beingaccessed in places where it eventually didn't get used. So this refactor
inlines the function appropriately in places where it was being used.
Also, this replaces uses of
AllocatedBufferswithBackingStores.Signed-off-by: Darshan Sen darshan.sen@postman.com
The text was updated successfully, but these errors were encountered: