ci: update default circle ci image to cimg/node:14.17.6
#43810
Closed
Conversation
alan-agius4
force-pushed
the
ci-update-circle-images
branch
2 times, most recently
from
9f0e63f
to
d426631
alan-agius4
force-pushed
the
ci-update-circle-images
branch
5 times, most recently
from
db68f0e
to
cb6f525
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images `circleci/node` with the new images `cimg/node`. See: https://circleci.com/developer/images/image/cimg/node
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later.
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime.
gkalpak
reviewed
Oct 12, 2021
Commit message typo:
-Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host.
+Spinning up a Node.js browsers image has little to no overhead when the image is cached on the host. Question: How likely is it for the image to be cached on the host?
|
@gkalpak, the commit message is actual correct. I did mean When the image is cached on host there isn't any overhead. |
|
You can preview b9c592b at https://pr43810-b9c592b.ngbuilds.io/. |
|
You can preview 0bd72e1 at https://pr43810-0bd72e1.ngbuilds.io/. |
gkalpak
requested changes
Oct 12, 2021
petebacondarwin
approved these changes
Oct 12, 2021
gkalpak
approved these changes
Oct 12, 2021
josephperrott
approved these changes
Oct 12, 2021
LGTM
|
This PR was merged into the repository by commit 17f5299. |
atscott
added a commit
that referenced
this issue
Oct 12, 2021
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later. PR Close #43810
atscott
added a commit
that referenced
this issue
Oct 12, 2021
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime. PR Close #43810
atscott
added a commit
that referenced
this issue
Oct 12, 2021
With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images `circleci/node` with the new images `cimg/node`. See: https://circleci.com/developer/images/image/cimg/node PR Close #43810
atscott
added a commit
that referenced
this issue
Oct 12, 2021
Eslint 8 which is used in AIO requires Node.js `14.17.x` or later. PR Close #43810
atscott
added a commit
that referenced
this issue
Oct 12, 2021
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host. `install_chrome_libs` however takes takes ~13s everytime. PR Close #43810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
build(docs-infra): update min range of node versions
Eslint 8 which is used in AIO requires Node.js
14.17.xor later.ci: update default circle ci image to
cimg/node:14.17.6With this change we update Node.js version to 14.17 which is needed because of Eslint 8. Also, we replace the legacy images
circleci/nodewith the new imagescimg/node.See: https://circleci.com/developer/images/image/cimg/node
ci: use Node.js browsers image
Spinning up a Node.js browsers image has little to no overhead when the image is not cached on the host.
install_chrome_libshowever takes takes ~13s every-time.The text was updated successfully, but these errors were encountered: