Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Deprecate StringLiteral.getRepresentedString() #7004

Merged
merged 4 commits into from Nov 2, 2021
Merged

Java: Deprecate StringLiteral.getRepresentedString() #7004

merged 4 commits into from Nov 2, 2021

Conversation

Reviewers

@aschackmull aschackmull

Assignees
No one assigned
Labels
documentation Java
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Marcono1234 @aschackmull
@Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Oct 29, 2021

See #6614 (comment)

Its behavior is the same as getValue() and it is therefore not needed anymore.
Marcono1234 added 2 commits Oct 29, 2021
@Marcono1234
Java: Deprecate `StringLiteral.getRepresentedString()`
bfb9577
@Marcono1234
Java: Describe `StringLiteral.getValue()` behavior for unpaired surro…
e1516b4 
…gates
@Marcono1234 Marcono1234 requested a review from as a code owner Oct 29, 2021
@github-actions github-actions bot added the Java label Oct 29, 2021
@Marcono1234 Marcono1234 mentioned this pull request Oct 29, 2021
Merged
@Marcono1234 Marcono1234 mentioned this pull request Oct 29, 2021
Closed
@aschackmull
Copy link
Contributor

@aschackmull aschackmull commented Oct 29, 2021

A short change note would be good.

@Marcono1234
Java: Add change note for `StringLiteral.getRepresentedString()` depr…
b284e72 
…ecation
@aschackmull
Copy link
Contributor

@aschackmull aschackmull commented Nov 1, 2021

A conflict due to #6614 being merged.

@Marcono1234
Merge branch 'main' into marcono1234/deprecate-StringLiteral-getRepre…
6689280 
…sentedString
@Marcono1234
Copy link
Contributor Author

@Marcono1234 Marcono1234 commented Nov 1, 2021

Sorry; the conflict should be resolved now.

@aschackmull aschackmull merged commit 42a046e into github:main Nov 2, 2021
8 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/deprecate-StringLiteral-getRepresentedString branch Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment