Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store actual ints, not pointers to them in the interpreter state. #29274

Merged
merged 1 commit into from Oct 28, 2021
Merged

Store actual ints, not pointers to them in the interpreter state. #29274

merged 1 commit into from Oct 28, 2021

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
3 participants
@markshannon @the-knights-who-say-ni @bedevere-bot
@markshannon
Copy link
Contributor

@markshannon markshannon commented Oct 28, 2021 •
edited
Loading

Make the array of small ints just that. An array of ints, not an array of pointers.
In theory should be a tiny bit faster, and removes a possible failure mode when creating the interpreter state.

Performance is about the same seemingly slowing down floats a bit, possibly because the float free list is now further from the start of the interpreter state.
@markshannon
Store actual ints, not pointers to them in the interpreter state.
1f0ccfe
@markshannon markshannon merged commit 4fc6856 into python:main Oct 28, 2021
11 checks passed
Loading
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 28, 2021
Open
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment