feat(bazel): allow for custom conditions to be set in ng_package targets
#43764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgets The APF v13 `ng_package` rule will generate the `exports` field if not set. Currently it allows for additional subpath entries to be configured manually. The packager does not allow for custom conditions in subpath exports which are auto-generated. This is sometimes useful and necessary though. e.g. in Angular Material, we also need to expose the index Sass file through a `sass` conditional that the Webpack Sass loader will pick up. For this, the packager needs to support manual additional conditions (as long as they do not conflict).
alxhub
approved these changes
Oct 7, 2021
clydin
approved these changes
Oct 7, 2021
atscott
added a commit
that referenced
this issue
Oct 7, 2021
…rgets (#43764) The APF v13 `ng_package` rule will generate the `exports` field if not set. Currently it allows for additional subpath entries to be configured manually. The packager does not allow for custom conditions in subpath exports which are auto-generated. This is sometimes useful and necessary though. e.g. in Angular Material, we also need to expose the index Sass file through a `sass` conditional that the Webpack Sass loader will pick up. For this, the packager needs to support manual additional conditions (as long as they do not conflict). PR Close #43764
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The APF v13
ng_packagerule will generate theexportsfield if notset. Currently it allows for additional subpath entries to be configured
manually. The packager does not allow for custom conditions in subpath
exports which are auto-generated though.
This is sometimes useful and necessary though. e.g. in Angular Material,
we also need to expose the index Sass file through a
sassconditionalthat the Webpack Sass loader will pick up. For this, the packager needs
to support manual additional conditions (as long as they do not
conflict).
Note: This should not fall under a feature for
feature-freezesince this isinternal code only necessary for our own tooling across Angular.
The text was updated successfully, but these errors were encountered: