Java: Factor out string prefix logic#6859
Merged
aschackmull merged 7 commits intoOct 19, 2021
Merged
Conversation
aschackmull
reviewed
Oct 13, 2021
| @@ -0,0 +1,151 @@ | |||
| /** | |||
| * Provides classes and predicates for identifying expressions that may be appended to an interesting prefix. | |||
Contributor
There was a problem hiding this comment.
This toplevel qldoc would really benefit from a Java code example to explain what's being identified where.
aschackmull
reviewed
Oct 19, 2021
| private import semmle.code.java.StringFormat | ||
|
|
||
| /** | ||
| * A string constant that contains a prefix whose possible successor strings are returned |
Contributor
There was a problem hiding this comment.
The term "successor string" sounds weird. Could we be more precise? E.g.
Suggested change
| * A string constant that contains a prefix whose possible successor strings are returned | |
| * A string constant that contains a prefix whose potentially appended suffix strings are returned |
aschackmull
reviewed
Oct 19, 2021
| * A string constant that contains a prefix whose possible successor strings are returned | ||
| * by `getAnAppendedExpression`. | ||
| * | ||
| * Extend this class to specify prefixes whose successors should be analysed. |
aschackmull
reviewed
Oct 19, 2021
| */ | ||
|
|
||
| import java | ||
| import semmle.code.java.dataflow.TaintTracking |
Contributor
There was a problem hiding this comment.
Suggested change
| import semmle.code.java.dataflow.TaintTracking | |
| private import semmle.code.java.dataflow.TaintTracking |
smowton
force-pushed
the
smowton/admin/factor-string-prefix
branch
from
6d1e4c8 to
d46b897
Compare
Contributor
Author
|
@aschackmull comments applied |
aschackmull
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An external contributor wants to re-use this logic, so here I factor it out to permit customisation with a different class of interesting prefix strings.