Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read MAPBOX_API_KEY from environment #16781

Open
frafra opened this issue Sep 22, 2021 · 2 comments · May be fixed by #16926
Open

Read MAPBOX_API_KEY from environment #16781

frafra opened this issue Sep 22, 2021 · 2 comments · May be fixed by #16926
Labels
good first issue viz:chart-maplayer

Comments

@frafra
Copy link
Contributor

@frafra frafra commented Sep 22, 2021 •
edited

All the settings are read from environment variables, except MAPBOX_API_KEY, which requires modifying superset_config.py.
https://github.com/apache/superset/blob/master/docker/pythonpath_dev/superset_config.py

https://github.com/apache/superset/blob/a330b664c13e34a4c7ca954f9a3a527a43a5535f/docs/src/pages/docs/frequently-asked-questions-page.mdx#why-is-the-map-not-visible-in-the-geospatial-visualization

It would be better just to add MAPBOX_API_KEY = get_env_variable("MAPBOX_API_KEY") somewhere in superset_config.py and add MAPBOX_API_KEY='' in docker/.env* files, and update the documentation accordingly.
@Lawful2002
Copy link

@Lawful2002 Lawful2002 commented Sep 29, 2021

@frafra I would like to work on this issue if it is still open.

@frafra
Copy link
Contributor Author

@frafra frafra commented Sep 29, 2021

@Lawful2002 sure, it is yours :)

@Lawful2002 Lawful2002 linked a pull request that will close this issue Sep 30, 2021
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue viz:chart-maplayer
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix: Read MAPBOX_API_KEY from environment
3 participants
@frafra @junlincc @Lawful2002