bpo-45575: Use a less ad-hoc approach to freelists, and use them for int and float freelists.#29165
Closed
markshannon wants to merge 8 commits into
Closed
bpo-45575: Use a less ad-hoc approach to freelists, and use them for int and float freelists.#29165markshannon wants to merge 8 commits into
markshannon wants to merge 8 commits into
Conversation
markshannon
changed the title
markshannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit d1ed5f6 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
asvetlov
reviewed
Oct 24, 2021
| /* Free lists. | ||
| * | ||
| * Free lists have a pointer to their first entry and | ||
| * the amunt of space available allowing fast checks |
Contributor
There was a problem hiding this comment.
Suggested change
| * the amunt of space available allowing fast checks | |
| * the amount of space available allowing fast checks |
Member
Author
|
Less of a speedup when adding multiple-interpreter support |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
Author
|
Closing this, as we should probably work towards integrating freelists with the memory allocator. |
Member
|
On our benchmarking machine this doesn't seem to show a 1% speedup: https://github.com/faster-cpython/benchmarking/blob/main/results/bm-20221014-3.12.0a0-d09385f/bm-20221014-linux-x86_64-faster%252dcpython-dry_freelists-3.12.0a0-d09385f-vs-base.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About ~1% faster
The speedup is modest, but this has potential for further improvement when better integrated with the underlying allocator.
https://bugs.python.org/issue45575