New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add `engines.node` field and node.js version check #1197

Merged

pi0 merged 6 commits into main from feat/engines-node

Oct 18, 2021

+46 −1

Member

pi0 commented Oct 18, 2021 •

edited

🔗 Linked issue

Resolves #800

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Ensure using latest Node.js version (Currently ^14.18.0 || ^16.11.0) to avoid unwanted issues due to old node version usage. We will keep maintaining this constraint under non-major releases to require LTS version of node as minimum.

Using package.json engines field + a background check in nuxi cli for all commands.

📝 Checklist

I have linked an issue or discussion.
I have updated the documentation accordingly.

The text was updated successfully, but these errors were encountered:


          feat(pkg): add `engines.node` field

595182a

netlify bot commented Oct 18, 2021 •

edited

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: a6c4176

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/616dc0039ab6ae0008c803b8


          feat(nuxi): runtime warning

895f993

pi0 changed the title ~~feat(pkg): add engines.node field~~ feat!: add engines.node field and node.js version check

pi0 marked this pull request as ready for review


          revert testing change

ef32853

pi0 marked this pull request as draft

pi0 added 3 commits


          Merge branch 'main' into feat/engines-node

9c24db9


          fix: interop default on semver

91caf6f


          reduce to minor

a6c4176

pi0 marked this pull request as ready for review

productdevbook reviewed

package.json

  
          @@ -56,6 +56,6 @@
        
              },

              "packageManager": "yarn@3.0.2",

              "engines": {

                "node": "^14.18.10 || ^16.11.0"

                "node": "^14.18.0 || ^16.11.0"

Contributor

productdevbook Oct 18, 2021 •

edited

I think it seems more correct this way? I was using this. "node": ">=14.18.0 || >=16.11.0"

Member Author

pi0 Oct 18, 2021 •

edited

Both equally work :) You can try with this playground using >= we also allow intermediate non-LTS versions like 15.x which are not recommand.

productdevbook approved these changes

danielroe approved these changes

pi0 merged commit d8d10fe into main

11 checks passed

pi0 deleted the feat/engines-node branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment