DES_Algorithm by GustavRamirez · Pull Request #5262 · TheAlgorithms/Python

GustavRamirez · 2021-10-12T16:39:58Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

A class for the implementation of DES algorithm

Made changes to conform with the given guidelines

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-10-12T16:40:03Z

+        [2, 1, 14, 7, 4, 10, 8, 13, 15, 12, 9, 0, 3, 5, 6, 11]
+    ]]
+
+    def single_string(self, s: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function single_string

Please provide descriptive name for the parameter: s

ghost · 2021-10-12T16:40:04Z

+        return '0' * (16 - len(temp)) + temp
+
+    # constructs the str by looking up the corresponding table
+    def crank(self, msg, table: list(int)) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function crank

Please provide type hint for the parameter: msg

ghost · 2021-10-12T16:40:04Z

+        return s
+
+    # makes long str presentable
+    def pretty(self, s: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function pretty

Please provide descriptive name for the parameter: s

ghost · 2021-10-12T16:40:05Z

+            ans += str(int(s1[i]) ^ int(s2[i]))
+        return ans
+
+    def s_box(self, msg: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function s_box

ghost · 2021-10-12T16:40:05Z

+            n += 1
+        return ans
+
+    def bits_shuffle(self, msg: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function bits_shuffle

ghost · 2021-10-12T16:40:06Z

+    def bits_shuffle(self, msg: str) -> str:
+        return self.crank(self.single_string(msg), self.bit_shuffle)
+
+    def generate_keys(self, key: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function generate_keys

ghost · 2021-10-12T16:40:06Z

+            self.shifted_keys.append(key)
+            self.keys.append(self.pc2(key))
+
+    def solve(self, msg: str, key: str, rnd: int) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function solve

ghost · 2021-10-12T16:40:06Z

+        print("Now applying PC-1 we get: ")
+        key = self.pc1(key)
+        print(self.pretty(key))
+        print("Rotating {} bit to the left we get:".format(self.shifts[rnd]))


As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-10-12T16:55:14Z

+        [2, 1, 14, 7, 4, 10, 8, 13, 15, 12, 9, 0, 3, 5, 6, 11]
+    ]]
+
+    def single_string(self, s: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function single_string

Please provide descriptive name for the parameter: s

ghost · 2021-10-12T16:55:14Z

+    def single_string(self, s: str) -> str:
+        return ''.join(s.split())
+
+    def hex_to_bin(self, n) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function hex_to_bin

Please provide type hint for the parameter: n

Please provide descriptive name for the parameter: n

ghost · 2021-10-12T16:55:15Z

+    def hex_to_bin(self, n) -> str:
+        return bin(int(n, 16))
+
+    def bin_to_hex(self, n) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function bin_to_hex

Please provide type hint for the parameter: n

Please provide descriptive name for the parameter: n

ghost · 2021-10-12T16:55:15Z

+        return '0' * (16 - len(temp)) + temp
+
+    # constructs the str by looking up the corresponding table
+    def crank(self, msg, table: list(int)) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function crank

Please provide type hint for the parameter: msg

ghost · 2021-10-12T16:55:15Z

+        return s
+
+    # makes long str presentable
+    def pretty(self, s: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function pretty

Please provide descriptive name for the parameter: s

ghost · 2021-10-12T16:55:16Z

+    def pc2(self, key):
+        return self.crank(self.single_string(key), self.pc2_table)
+
+    def xor(self, s1: str, s2: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function xor

ghost · 2021-10-12T16:55:16Z

+            ans += str(int(s1[i]) ^ int(s2[i]))
+        return ans
+
+    def s_box(self, msg: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function s_box

ghost · 2021-10-12T16:55:16Z

+            n += 1
+        return ans
+
+    def bits_shuffle(self, msg: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function bits_shuffle

ghost · 2021-10-12T16:55:16Z

+    def bits_shuffle(self, msg: str) -> str:
+        return self.crank(self.single_string(msg), self.bit_shuffle)
+
+    def generate_keys(self, key: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function generate_keys

ghost · 2021-10-12T16:55:16Z

+            self.shifted_keys.append(key)
+            self.keys.append(self.pc2(key))
+
+    def solve(self, msg: str, key: str, rnd: int) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function solve

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-10-12T17:01:59Z

+        [2, 1, 14, 7, 4, 10, 8, 13, 15, 12, 9, 0, 3, 5, 6, 11]
+    ]]
+
+    def single_string(self, s: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function single_string

Please provide descriptive name for the parameter: s

ghost · 2021-10-12T17:01:59Z

+        return '0' * (16 - len(temp)) + temp
+
+    # constructs the str by looking up the corresponding table
+    def crank(self, msg, table: list(int)) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function crank

Please provide type hint for the parameter: msg

ghost · 2021-10-12T17:01:59Z

+        return s
+
+    # makes long str presentable
+    def pretty(self, s: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function pretty

Please provide descriptive name for the parameter: s

ghost · 2021-10-12T17:02:00Z

+    def pc2(self, key):
+        return self.crank(self.single_string(key), self.pc2_table)
+
+    def xor(self, s1: str, s2: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function xor

ghost · 2021-10-12T17:02:01Z

+            ans += str(int(s1[i]) ^ int(s2[i]))
+        return ans
+
+    def s_box(self, msg: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function s_box

ghost · 2021-10-12T17:02:01Z

+            n += 1
+        return ans
+
+    def bits_shuffle(self, msg: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function bits_shuffle

ghost · 2021-10-12T17:02:01Z

+    def bits_shuffle(self, msg: str) -> str:
+        return self.crank(self.single_string(msg), self.bit_shuffle)
+
+    def generate_keys(self, key: str) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function generate_keys

ghost · 2021-10-12T17:02:01Z

+            self.shifted_keys.append(key)
+            self.keys.append(self.pc2(key))
+
+    def solve(self, msg: str, key: str, rnd: int) -> str:


As there is no test file in this pull request nor any test function or class in the file ciphers/des_algorithm.py, please provide doctest for the function solve

GustavRamirez

Updated type hints and some other issues

stale · 2022-07-10T22:22:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cclauss · 2022-10-01T10:59:43Z

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that do not have passing tests.

GustavRamirez added 2 commits October 12, 2021 20:46

DES Algorithm

f3c5fa9

A class for the implementation of DES algorithm

Updated to cornform with guidelines

f851e79

Made changes to conform with the given guidelines

ghost added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 12, 2021

ghost reviewed Oct 12, 2021

View reviewed changes

Changed .format to f string

c851f59

ghost reviewed Oct 12, 2021

View reviewed changes

Added type hints

fd42378

ghost reviewed Oct 12, 2021

View reviewed changes

GustavRamirez commented Oct 12, 2021

View reviewed changes

ghost added the tests are failing Do not merge until tests pass label Oct 14, 2021

stale Bot added the stale Used to mark an issue or pull request stale. label Jul 10, 2022

cclauss closed this Oct 1, 2022

Uh oh!

Conversation

GustavRamirez commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

GustavRamirez commented Oct 12, 2021 •

edited

Loading