Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magnitude and Angle of Vector #5225

Merged
merged 6 commits into from Oct 12, 2021
Merged

Magnitude and Angle of Vector #5225

merged 6 commits into from Oct 12, 2021
+30 −0

Conversation

@AMANKANOJIYA
Copy link
Contributor

@AMANKANOJIYA AMANKANOJIYA commented Oct 11, 2021

Describe your change:

Core function to find Magnitude and Angle of two Given Vector

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@AMANKANOJIYA
Magnitude and Angle
efca208 
Core function to find Magnitude and Angle of two Given Vector
cclauss
cclauss requested changes Oct 11, 2021
View changes
linear_algebra/src/lib.py Outdated
def magnitude(self) -> float:
'''
Magnitude of a Vector
'''
Copy link
Member

@cclauss cclauss Oct 11, 2021

No doctest

Copy link
Member

@cclauss cclauss Oct 11, 2021

Please add doctests for negative numbers and zero.

Copy link
Contributor

@Rohanrbharadwaj Rohanrbharadwaj Oct 11, 2021

And use double quotes

linear_algebra/src/lib.py Show resolved Hide resolved
@AMANKANOJIYA
Magnitude and Angle with Doctest
2fc782e 
added Doctest to the functions
@AMANKANOJIYA
Copy link
Contributor Author

@AMANKANOJIYA AMANKANOJIYA commented Oct 11, 2021

Added DocTest to the file

cclauss
cclauss reviewed Oct 11, 2021
View changes
linear_algebra/src/lib.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Oct 11, 2021
View changes
linear_algebra/src/lib.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Oct 11, 2021
View changes
linear_algebra/src/lib.py Outdated Show resolved Hide resolved
AMANKANOJIYA and others added 4 commits Oct 11, 2021
@AMANKANOJIYA @cclauss
Update linear_algebra/src/lib.py
0350a9d 
Co-authored-by: Christian Clauss <cclauss@me.com>
@AMANKANOJIYA @cclauss
Update linear_algebra/src/lib.py
cde040f 
Co-authored-by: Christian Clauss <cclauss@me.com>
@AMANKANOJIYA
Changes done
02fc704 
and Magnitude and Angle Issues
@cclauss
black
ef01d09
cclauss
cclauss approved these changes Oct 12, 2021
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM

Thanks for doing this!

@cclauss cclauss merged commit 1b0ac73 into TheAlgorithms:master Oct 12, 2021
2 checks passed
@AMANKANOJIYA
Copy link
Contributor Author

@AMANKANOJIYA AMANKANOJIYA commented Oct 12, 2021

Welcome. I will Love to contribute more to this Community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rohanrbharadwaj Rohanrbharadwaj

@cclauss cclauss

Assignees
No one assigned
Labels
enhancement hacktoberfest-accepted hacktoberfest
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@AMANKANOJIYA @cclauss @Rohanrbharadwaj