Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: add pragma[noinline] to predicates where the qldoc mentions join-order #6881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JS: add pragma[noinline] to predicates where the qldoc mentions join-order #6881

wants to merge 1 commit into from

Conversation

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Oct 14, 2021 •
edited

The qldoc suggests that the predicate should not be inlined, but that wasn't enforced by a pragma.

Evaluation looks safe.
@erik-krogh
add pragma[noinline] to predicates where the qldoc mentions join-order
047aee3
@github-actions github-actions bot added the JS label Oct 14, 2021
@erik-krogh erik-krogh marked this pull request as ready for review Oct 14, 2021
@erik-krogh erik-krogh requested a review from as a code owner Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-javascript codeql-javascript

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@erik-krogh