Skip to content

/ SwifterSwift Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIImage.filled(withColor: ) missing clip mask above iOS10 #849

Open
miku1958 opened this issue May 22, 2020 · 1 comment
Open

UIImage.filled(withColor: ) missing clip mask above iOS10 #849

miku1958 opened this issue May 22, 2020 · 1 comment
Labels
good first issue help wanted needs investigation possible bug

Comments

@miku1958
Copy link

@miku1958 miku1958 commented May 22, 2020 •
edited

current code

        #if !os(watchOS)
        if #available(tvOS 10.0, *) {
            let format = UIGraphicsImageRendererFormat()
            format.scale = scale
            let renderer = UIGraphicsImageRenderer(size: size, format: format)
            return renderer.image { context in
                color.setFill()
                context.fill(CGRect(origin: .zero, size: size))
            }
        }
        #endif

just render a color to image
it should add

context.cgContext.clip(to: rect, mask: mask)

before color.setFill()

and also, the result after using UIGraphicsImageRenderer is different from old version, the old version is fliped vertically
@LucianoPAlmeida
Copy link
Member

@LucianoPAlmeida LucianoPAlmeida commented May 23, 2020

Thanks for reporting @miku1958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted needs investigation possible bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@LucianoPAlmeida @miku1958