Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44145: Release the GIL around HMAC_Update. #26157

Merged
merged 1 commit into from May 17, 2021
Merged

bpo-44145: Release the GIL around HMAC_Update. #26157

merged 1 commit into from May 17, 2021

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented May 16, 2021 •
edited by miss-islington

It was always meant to be released for parallelization.
Thanks michaelforney for noticing.

https://bugs.python.org/issue44145

Automerge-Triggered-By: GH:gpshead
@gpshead
bpo-44145: Release the GIL around HMAC_Update.
7c46204 
It was always meant to be released for parallelization.
Thanks michaelforney for noticing.
@gpshead gpshead requested a review from tiran May 16, 2021
@gpshead gpshead closed this May 16, 2021
@gpshead gpshead reopened this May 16, 2021
@gpshead gpshead closed this May 16, 2021
@gpshead gpshead reopened this May 16, 2021
@tiran
Copy link
Member

@tiran tiran commented May 16, 2021

Is github having issues?

  remote: Internal Server Error.
  remote: 
  Error: fatal: unable to access 'python/cpython': The requested URL returned error: 500
  The process '/usr/bin/git' failed with exit code 128

@tiran tiran closed this May 16, 2021
@tiran tiran reopened this May 16, 2021
@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented May 16, 2021

Is github having issues?

  remote: Internal Server Error.
  remote: 
  Error: fatal: unable to access 'python/cpython': The requested URL returned error: 500
  The process '/usr/bin/git' failed with exit code 128

Yes GH actions seems to have problems: https://www.githubstatus.com/incidents/zbpwygxwb3gw

@gpshead gpshead closed this May 16, 2021
@gpshead gpshead reopened this May 16, 2021
@gpshead gpshead merged commit c10392e into python:main May 17, 2021
37 of 45 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 17, 2021

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@gpshead gpshead deleted the hmac-update-gil-release branch May 17, 2021
miss-islington added a commit to miss-islington/cpython that referenced this issue May 17, 2021
@gpshead @miss-islington
bpo-44145: Release the GIL around HMAC_Update. (pythonGH-26157)
3be8ca6 
It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 17, 2021

GH-26187 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 17, 2021

GH-26188 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue May 17, 2021
@gpshead @miss-islington
bpo-44145: Release the GIL around HMAC_Update. (pythonGH-26157)
3b38d89 
It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this issue May 17, 2021
@gpshead @miss-islington
bpo-44145: Release the GIL around HMAC_Update. (GH-26157)
60fa8b3 
It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this issue May 17, 2021
@miss-islington
[3.9] bpo-44145: Release the GIL around HMAC_Update. (GH-26157) (GH-2…
2057ce8 
…6188)

It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)


Co-authored-by: Gregory P. Smith <greg@krypto.org>

Automerge-Triggered-By: GH:gpshead
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
stratakis added a commit to stratakis/cpython that referenced this issue Aug 5, 2021
@gpshead @miss-islington @stratakis
bpo-44145: Release the GIL around HMAC_Update. (pythonGH-26157)
d4e60ec 
It was always meant to be released for parallelization.
This now matches the other similar code in the module.

Thanks michaelforney for noticing!
(cherry picked from commit c10392e)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees

@tiran tiran

Labels
CLA signed 🤖 automerge type-bugfix type-performance
Projects
None yet
Milestone
No milestone
6 participants
@gpshead @tiran @Fidget-Spinner @miss-islington @bedevere-bot @the-knights-who-say-ni