Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the order of a stacked abstractmethod #26892

Merged
merged 5 commits into from Jun 27, 2021
Merged

Clarify the order of a stacked abstractmethod #26892

merged 5 commits into from Jun 27, 2021

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 24, 2021

Hey, I hope we can do without an issue number for this one. Every time I see the text "Deprecated, use 'property' with 'abstractmethod' instead" I have to scratch my head and think which one of the two decorators goes on top. This way it's clearer.

@taleinat taleinat self-assigned this Jun 27, 2021
@taleinat taleinat added skip issue skip news docs Documentation in the Doc dir labels Jun 27, 2021
taleinat
taleinat requested changes Jun 27, 2021
View changes
Lib/abc.py Outdated Show resolved Hide resolved
Lib/abc.py Outdated Show resolved Hide resolved
Lib/abc.py Outdated Show resolved Hide resolved
Lib/abc.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Jun 27, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

cool-RR and others added 2 commits Jun 27, 2021
@cool-RR @taleinat
Apply suggestions from code review
445e9d5 
Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
@cool-RR
Apply more suggestions from code review
eb06fd1
taleinat
taleinat reviewed Jun 27, 2021
View changes
Lib/abc.py Outdated Show resolved Hide resolved
cool-RR and others added 2 commits Jun 27, 2021
@cool-RR @taleinat
Update Lib/abc.py
db5d388 
Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
@cool-RR
Apply even more suggestions from code review
56dda1d
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 27, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Jun 27, 2021

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from taleinat Jun 27, 2021
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 27, 2021

I'm assuming the failed tests are bullshit and can be ignored.

@taleinat
Copy link
Contributor

taleinat commented Jun 27, 2021

Yes, it's a flaky test, but the check is considered required so I restarted it and we must wait for it to complete.

@taleinat taleinat merged commit 74d60ea into python:main Jun 27, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jun 27, 2021

Thanks @cool-RR for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 27, 2021

GH-26925 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jun 27, 2021

GH-26926 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2021
@cool-RR @miss-islington
Clarify the order of a stacked abstractmethod (pythonGH-26892)
c9f940c 
Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
(cherry picked from commit 74d60ea)

Co-authored-by: Ram Rachum <ram@rachum.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2021
@cool-RR @miss-islington
Clarify the order of a stacked abstractmethod (pythonGH-26892)
6a961ab 
Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
(cherry picked from commit 74d60ea)

Co-authored-by: Ram Rachum <ram@rachum.com>
miss-islington added a commit that referenced this pull request Jun 27, 2021
@miss-islington @cool-RR
Clarify the order of a stacked abstractmethod (GH-26892)
b2a5dcd 
Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
(cherry picked from commit 74d60ea)

Co-authored-by: Ram Rachum <ram@rachum.com>
miss-islington added a commit that referenced this pull request Jun 27, 2021
@miss-islington @cool-RR
Clarify the order of a stacked abstractmethod (GH-26892)
c95cdf2 
Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
(cherry picked from commit 74d60ea)

Co-authored-by: Ram Rachum <ram@rachum.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat

Assignees

@taleinat taleinat

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cool-RR @bedevere-bot @taleinat @miss-islington @the-knights-who-say-ni