-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
bpo-45411: Update mimetypes.py #28792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.vtt and .srt files are common subtitle files, used by browsers.
|
Looks good to me, |
|
@Josephine-Marie Can you add a short NEWS entry like |
|
yes, sorry I forgot, I hope it is fine that I used 00000 as a bug number since this has none. |
|
Awww yes, forgot that NEWS issues have to be linked to an issue... (no you can't use 0000 sadly). To do things properly you should open an issue on bugs.python.org, I tried bypassing that for simplicity but it won't do ;) |
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Misc/NEWS.d/next/Library/2021-10-08-11-29-29.bpo-45411.4jR--U.rst
Outdated
Show resolved
Hide resolved
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Misc/NEWS.d/next/Library/2021-10-07-13-48-53.bpo-00000.1md5vg.rst
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| Add Subtitle file extensions for enhancing web development with Python! | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer it more precise, tell which file extensions, tell about it's in the mimetypes module, and you can remove the part about web dev: having those extensions recognized by mimetypes is nice everywhere, not just for web dev ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, hope this is better and not too short
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Looks good to me! I know the first PR in cpython may be overwelming, but there's one last little step: you'll need to sign the CLA, the why and how is described here: https://devguide.python.org/pullrequest/#cla. |
|
I did, it says that I signed and its all correct. Thank you so much for your help @JulienPalard |
|
Thanks @Josephine-Marie for your first PR in Python! |
.vtt and .srt files are common subtitle files, beneficial for people who use python for web development.
https://bugs.python.org/issue45411