Skip to content

Conversation

Josephine-Marie
Copy link
Contributor

@Josephine-Marie Josephine-Marie commented Oct 7, 2021

.vtt and .srt files are common subtitle files, beneficial for people who use python for web development.

https://bugs.python.org/issue45411

.vtt and .srt files are common subtitle files, used by browsers.
@JulienPalard
Copy link
Member

Looks good to me, text/vtt is has IANA registration https://www.iana.org/assignments/media-types/text/vtt and .srt is well known plain/text https://www.matroska.org/technical/subtitles.html#srt-subtitles.

@JulienPalard
Copy link
Member

@Josephine-Marie Can you add a short NEWS entry like Add MIME types for ...? See https://devguide.python.org/ about how to do it.

@blurb-it blurb-it bot requested a review from tiran as a code owner October 7, 2021 13:48
@Josephine-Marie
Copy link
Contributor Author

yes, sorry I forgot, I hope it is fine that I used 00000 as a bug number since this has none.

@JulienPalard
Copy link
Member

Awww yes, forgot that NEWS issues have to be linked to an issue... (no you can't use 0000 sadly).

To do things properly you should open an issue on bugs.python.org, I tried bypassing that for simplicity but it won't do ;)

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Josephine-Marie

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Josephine-Marie Josephine-Marie changed the title Update mimetypes.py bpo-45411: Update mimetypes.py Oct 8, 2021
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Josephine-Marie

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@@ -0,0 +1 @@
Add Subtitle file extensions for enhancing web development with Python!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer it more precise, tell which file extensions, tell about it's in the mimetypes module, and you can remove the part about web dev: having those extensions recognized by mimetypes is nice everywhere, not just for web dev ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, hope this is better and not too short

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Josephine-Marie

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Josephine-Marie

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@JulienPalard
Copy link
Member

Looks good to me!

I know the first PR in cpython may be overwelming, but there's one last little step: you'll need to sign the CLA, the why and how is described here: https://devguide.python.org/pullrequest/#cla.

@Josephine-Marie
Copy link
Contributor Author

I did, it says that I signed and its all correct. Thank you so much for your help @JulienPalard

@JulienPalard
Copy link
Member

Thanks @Josephine-Marie for your first PR in Python!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants