Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd configuration options to override Benchee default values #45
Comments
|
Default config can be found here: https://github.com/PragTob/benchee/blob/master/lib/benchee/config.ex#L156 Example for mix config: https://hexdocs.pm/mix/Mix.Config.html |
|
Is it ok for config to be included at compile time? |
|
Working on this. |
|
So, in light of the recent configuration guidelines, should we still do this? I think we can totally get away without application config. |
|
It's something that I still don't fully understand. I still think saying that I always want to use the HTML formatter might be useful and I dunno how else to best do it otherwise. On the other hand, if people want that they could write their own little wrapper. |
|
We could do what Credo does and have a |
|
Good point Although until we have a way to specify paths without mentioning the file name this isn't essential to me. So I'll also remove the 1.0 milestone |
Benchee is getting a lot of configuration options - which is great. But the more configurations options and formatters there are, the more people would probably prefer to configure some of them globally for their project.
Something like:
config :benchee, :options, %{} # fancy map or keyword list overriding default optionsThese options should then represent the new default options. So merge order would be something like: default_config <- app_config <- benchmark_config (<- meaning right overrides left)