Python: Merge SQLAlchemy TextClause injection into py/sql-injection#6727
Merged
yoff merged 2 commits intogithub:mainfrom Sep 22, 2021
Merged
Python: Merge SQLAlchemy TextClause injection into py/sql-injection#6727yoff merged 2 commits intogithub:mainfrom
py/sql-injection#6727yoff merged 2 commits intogithub:mainfrom
Conversation
As discussed in a meeting today, this will end up presenting an query suite that's easier to use for customers. Since github#6589 has JUST been merged, if we get this change in fast enough, no end-user will ever have run `py/sqlalchemy-textclause-injection` as part of LGTM.com or Code Scanning.
|
|
||
| <p> | ||
| This also includes using the <code>TextClause</code> class in the | ||
| <a href="https://pypi.org/project/SQLAlchemy/"><code>SQLAlchemy</code></a> PyPI package, |
Contributor
There was a problem hiding this comment.
Does <code> work inside <a href>?
I thought I remembered a case were it didn't work.
Member
Author
There was a problem hiding this comment.
Thanks, I forgot to test it locally. You're right, but it does work if you flip the <a> and <code> tags 🤷
yoff
approved these changes
Sep 22, 2021
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
LGTM - as discussed offline, TextArgAsSink can be generalised later.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in a meeting today, this will end up presenting an query suite that's easier to use for customers.
Since #6589 has JUST been merged, if we get this change in fast enough, no end-user will ever have run
py/sqlalchemy-textclause-injectionas part of LGTM.com or Code Scanning.