Skip to content

/ Python Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy scripts #4320

Merged
merged 1 commit into from Apr 7, 2021
Merged

Fix mypy scripts #4320

merged 1 commit into from Apr 7, 2021

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Apr 6, 2021 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@cclauss
Fix mypy scripts
1fa8da8
@cclauss cclauss requested a review from dhruvmanila Apr 6, 2021
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Apr 6, 2021

The builds are stuck again. I contacted GitHub but at the time of their reply our builds were working fine. I haven't received another reply yet.

@cclauss
Copy link
Member Author

@cclauss cclauss commented Apr 6, 2021

The tests finish on a delayed basis.

@dhruvmanila dhruvmanila merged commit 252df0a into TheAlgorithms:master Apr 7, 2021
4 checks passed
@cclauss cclauss deleted the mypy_scripts branch Apr 7, 2021
Panquesito7 pushed a commit to Panquesito7/Python that referenced this issue May 13, 2021
@cclauss
fix(mypy): Fix files in scripts/ (TheAlgorithms#4320)
ec5468e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cclauss @dhruvmanila