Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain how to handle skipped required checks #8926

Closed
1 task done
jsoref opened this issue Aug 10, 2021 · 10 comments · Fixed by #9126
Closed
1 task done

Explain how to handle skipped required checks #8926

jsoref opened this issue Aug 10, 2021 · 10 comments · Fixed by #9126
Labels
content Problems or updates in the docs content on docs.github.com. help wanted Anyone is welcome to open a pull request to fix this issue.
Projects
Docs open source board

Comments

@jsoref
Copy link
Contributor

jsoref commented Aug 10, 2021

Code of Conduct

  • I have read and agree to the GitHub Docs project's Code of Conduct.

What article on docs.github.com is affected?

https://github.com/github/docs/blob/2289ca70c7ec7ec1b81eafdb333cd0157fafaa08/content/github/administering-a-repository/troubleshooting-required-status-checks.md

What part(s) of the article would you like to see updated?

A section should be added that explains that if people use paths for a required check, they'll want to add a second copy of the check with paths-ignore for the same content that just returns true.

Additional information

It's a FAQ in https://github.community
@jsoref jsoref added the content Problems or updates in the docs content on docs.github.com. label Aug 10, 2021
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Aug 10, 2021
@github-actions github-actions bot added this to Triage in Docs open source board Aug 10, 2021
@Fadiabukhadrah

This comment has been minimized.

Sign in to view
@ramyaparimi ramyaparimi moved this from Triage to Content review needed in Docs open source board Aug 11, 2021
@ramyaparimi ramyaparimi removed the triage Do not begin working on this issue until triaged by the team. label Aug 11, 2021
@lecoursen
Copy link
Member

lecoursen commented Aug 17, 2021

It's a FAQ in https://github.community

Hi @jsoref, could you link to one or more examples? Thanks!

@jsoref
Copy link
Contributor Author

jsoref commented Aug 17, 2021 •
edited

https://github.community/t/github-pull-request-is-waiting-for-required-status-checks-even-with-ci-skip-in-commit-message/827
https://github.community/t/github-actions-checks-when-not-in-triggers/194399
https://github.community/t/pr-stuck-waiting-for-checks-which-should-be-skipped/18485
https://github.community/t/feature-request-conditional-required-checks/16761
https://github.community/t/skip-ci-ci-skip-dont-work-if-a-repo-has-branch-protection-enabled-travis-ci-pull-request/15326
https://github.community/t/github-actions-and-required-checks-in-a-monorepo-using-paths-to-limit-execution/16586
https://github.community/t/dealing-with-checks-enforced-by-branch-protection-but-skipped-by-path-filter/18451
https://github.community/t/monorepos-and-limiting-workflows-by-changed-files-required-status-checks/136030
https://github.community/t/force-succeed-required-workflow-when-skipped/124055
https://github.community/t/path-filtering-on-required-pull-request-checks/18402

@lecoursen
Copy link
Member

lecoursen commented Aug 17, 2021

Thanks @jsoref! This sounds like a great plan that will address a very common source of confusion. You or anyone else is welcome to open that PR! ⚡

@lecoursen lecoursen added the help wanted Anyone is welcome to open a pull request to fix this issue. label Aug 17, 2021
@docubot docubot moved this from Content review needed to Help wanted in Docs open source board Aug 17, 2021
@thispsj thispsj mentioned this issue Aug 18, 2021
Merged
2 tasks
@lmoureaux lmoureaux mentioned this issue Sep 12, 2021
Closed
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 17, 2021
@ramyaparimi ramyaparimi removed the stale There is no recent activity on this issue or pull request label Oct 18, 2021
Docs open source board automation moved this from Help wanted to Done Nov 29, 2021
hubwriter added a commit that referenced this issue Nov 29, 2021
@thispsj @hubwriter
Add how to troubleshoot skipped but required checks (#9126)
4364076 
* Update troubleshooting-required-status-checks.md

* Add troubleshooting info

Adds how to handle skipped required checks.

Fixes #8926

* Fix generic workflow

* Add a note about other CI/CD

* Add images

* Added images

* Delete troubleshooting-required-status-checks.md

* Fix merge conflicts

* Remove blank lines

Co-authored-by: hubwriter <hubwriter@github.com>

* Apply styling

* Group notes into one

* Remove older images

* Remove images

* Added suggested images

* Update content/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks.md

Co-authored-by: hubwriter <hubwriter@github.com>
@Fran-Rg
Copy link

Fran-Rg commented Aug 24, 2022

Because I landed here from google search, the documented solution is here: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks

@TWiStErRob
Copy link
Contributor

TWiStErRob commented Nov 6, 2022

@jsoref I'm trying to research this topic, but all the links in #8926 (comment) are dead. Where can I find those old forum topics?

@jsoref
Copy link
Contributor Author

jsoref commented Nov 6, 2022

Dunno. They did a real number in github.community in their migration. It didn't occur to me when I filed this that I'd need to quote the full contents of each item here...

@TWiStErRob
Copy link
Contributor

TWiStErRob commented Nov 6, 2022

I tried searching for some slugs without dashes but no results, not even on Google.

@jsoref
Copy link
Contributor Author

jsoref commented Nov 6, 2022

@TWiStErRob IA appears to have at least some of them..., here's an example: https://web.archive.org/web/20200928033538/https://github.community/t/github-pull-request-is-waiting-for-required-status-checks-even-with-ci-skip-in-commit-message/827

@TWiStErRob
Copy link
Contributor

TWiStErRob commented Nov 6, 2022

Oo nice, forgot about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Problems or updates in the docs content on docs.github.com. help wanted Anyone is welcome to open a pull request to fix this issue.
Projects
Docs open source board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add how to troubleshoot skipped but required checks
8 participants
@jsoref @TWiStErRob @Fran-Rg @lecoursen @ramyaparimi @Fadiabukhadrah and others