Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spider.state attribute is not documented #5174

Closed
kmike opened this issue Jun 7, 2021 · 4 comments
Closed

spider.state attribute is not documented #5174

kmike opened this issue Jun 7, 2021 · 4 comments
Labels
docs enhancement good first issue

Comments

@kmike
Copy link
Member

kmike commented Jun 7, 2021 •
edited
Loading

spider.state is not mentioned on https://docs.scrapy.org/en/latest/topics/spiders.html; it is only mentioned here: https://docs.scrapy.org/en/latest/topics/jobs.html#keeping-persistent-state-between-batches. It'd be nice to document this attribute.
@kmike kmike mentioned this issue Jun 7, 2021
Open
@arnavsshah
Copy link

@kmike is this a good issue for my first time contributing to scrapy?

@Gallaecio
Copy link
Member

This would may be a good first issue, yes, given https://docs.scrapy.org/en/latest/topics/jobs.html#keeping-persistent-state-between-batches

kamran890 added a commit to kamran890/scrapy that referenced this issue Sep 21, 2021
@kamran890
Document spider.state attribute (scrapy#5174)
176d810
kamran890 added a commit to kamran890/scrapy that referenced this issue Sep 21, 2021
@kamran890
Document spider.state attribute (scrapy#5174)
e5998fb
wRAR added a commit that referenced this issue Sep 27, 2021
@wRAR
Merge pull request #5244 from kamran890/spider-state-doc
6249175 
Document spider.state attribute (#5174)
@ahudspeth199
Copy link

Can I still get involved with this? I am new to python coding not sure where to start?

@wRAR
Copy link
Member

wRAR commented Oct 2, 2021

Closed by #5244.

@wRAR wRAR closed this as completed Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kmike @wRAR @Gallaecio @arnavsshah @ahudspeth199