Skip to content

GitHub context fix#10018

Merged
skedwards88 merged 3 commits into
github:mainfrom
EmilyGraceSeville7cf:patch-2
Sep 27, 2021
Merged

GitHub context fix#10018
skedwards88 merged 3 commits into
github:mainfrom
EmilyGraceSeville7cf:patch-2

Conversation

@EmilyGraceSeville7cf
Copy link
Copy Markdown
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Sep 13, 2021

  • script names fixed

Why:

Closes #10017

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

GitHub context fix
8fdadb9 
- script names fixed
@welcome
Copy link
Copy Markdown

welcome Bot commented Sep 13, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Sep 13, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Sep 13, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Sep 13, 2021

@alvinseville7cf
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@EmilyGraceSeville7cf
Copy link
Copy Markdown
Contributor Author

EmilyGraceSeville7cf commented Sep 18, 2021 •
edited
Loading

I don't understand what I have to do now. Nothing? :) (I am asking because 22 workflows are awaiting approval.)

@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Sep 20, 2021

@emilyseville7cf Yep!! Those workflows are waiting for an approval, so everything should run once the changes are reviewed and approved 👍 🐬 Thanks a bunch for your patience 💖

skedwards88
skedwards88 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for this correction! I'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Sep 23, 2021
@github-actions github-actions Bot removed the waiting for review Issue/PR is waiting for a writer's review label Sep 23, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Sep 23, 2021

@emilyseville7cf It looks like I don't have permission to resolve the merge conflict. I think if you enable the checkbox to allow maintainer edits, then I will be able to resolve this. (https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork ) Alternatively, could you resolve the merge conflict?

@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Sep 24, 2021

@emilyseville7cf The PR has some unresolved conflicts which is blocking the merge process 💛 Could you please try resolving the conflict by merging into your working branch from main? Once the conflicts are resolved, I will be able to merge this PR ✨

Thanks so much for your time in contributing to the GitHub docs 💖

@EmilyGraceSeville7cf
Copy link
Copy Markdown
Contributor Author

EmilyGraceSeville7cf commented Sep 25, 2021 •
edited
Loading

Could you please try resolving the conflict by merging into your working branch from main?

Yeah, I can. I will do it as soon as possible.

@EmilyGraceSeville7cf
Copy link
Copy Markdown
Contributor Author

EmilyGraceSeville7cf commented Sep 27, 2021

@ramyaparimi, everything is ready.

@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Sep 27, 2021

@emilyseville7cfg
Can you enable the checkbox to allow maintainer edits? Then I'll be able to hit the update button and get this merged in. Thank you! https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Thanks so much for your patience 💖

@EmilyGraceSeville7cf
Copy link
Copy Markdown
Contributor Author

EmilyGraceSeville7cf commented Sep 27, 2021 •
edited
Loading

@ramyaparimi, this checkbox (Allow edits and access to secrets by maintainers) is already enabled. :)

@skedwards88 skedwards88 enabled auto-merge (squash) September 27, 2021 16:44
@skedwards88 skedwards88 merged commit dc5ad58 into github:main Sep 27, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 27, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

@Lakho145 Lakho145 Lakho145 approved these changes

@Luimoll Luimoll Luimoll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

github.action description is wrong

6 participants

@EmilyGraceSeville7cf @ramyaparimi @skedwards88 @Lakho145 @Luimoll @docubot