Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't use an environment variable in request body #1834

Open
zecrazytux opened this issue Sep 23, 2021 · 7 comments
Open

can't use an environment variable in request body #1834

zecrazytux opened this issue Sep 23, 2021 · 7 comments

Comments

@zecrazytux
Copy link

@zecrazytux zecrazytux commented Sep 23, 2021

Describe the bug
environment <> should be useable within a raw request body, but it isn't

To Reproduce
create an env variable, eg "user"
use it (<>) into url: it works
use it (<>) into the raw request body textarea: it is not replaced with var content

Expected behavior
<> should be replaced with env var content

Screenshots
image

Desktop (please complete the following information):
chrome

@liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Sep 23, 2021

@zecrazytux thank you reporting this behaviour. We'll be taking a look into this as soon as possible.

@dhivyasreedhar
Copy link

@dhivyasreedhar dhivyasreedhar commented Sep 29, 2021

Hi, can I work on this issue?

@liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Sep 29, 2021

Hi @dhivyasreedhar, thanks for showing interest in working on this issue. You're free to take up this. I'm assigning it to you, contact us if you need any help.

@rishabhkalra96
Copy link
Contributor

@rishabhkalra96 rishabhkalra96 commented Oct 4, 2021

Hi @liyasthomas, Is this issue still been looked into?
I'd like to take this up if @dhivyasreedhar is no longer working on it.

@liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Oct 4, 2021

Hi @rishabhkalra96, I guess you can pick up this, thanks for showing interest on contributing to Hoppscotch.

@rishabhkalra96
Copy link
Contributor

@rishabhkalra96 rishabhkalra96 commented Oct 6, 2021

Hi @liyasthomas Based on my primary investigation i think its not a bug but an enhancement. The expectation we have from the raw body is not implemented yet. I could be wrong, would love to have some guidance here.
Also, of note, i am just starting off with OSS and vue specifically, so i might take little bit more time than expected.

Also, can you please tell me which is the current branch for development ? Although i have come here from hacktoberfest, but i want to contribute more into the product outside of the fest too.

@liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Oct 9, 2021

Hi @rishabhkalra96, you can create a branch with main as the base. Also, raise the PR to the main branch as well.

And yes, environment support in the body is not a bug but rather an enhancement that hasn't been implemented. Let me know if you've any specific doubts from the codebases or in Vue.js - happy to help.

@liyasthomas liyasthomas added feature and removed bug labels Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants